Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make get_tools isn't installing gometalinter #1190

Closed
ValarDragon opened this issue Jun 9, 2018 · 1 comment · Fixed by #1337
Closed

Make get_tools isn't installing gometalinter #1190

ValarDragon opened this issue Jun 9, 2018 · 1 comment · Fixed by #1337
Assignees
@ValarDragon
Labels
good first issue T: CI

Comments

@ValarDragon
Copy link
Contributor

ValarDragon commented Jun 9, 2018 •
edited
Loading

Make get_tools isn't installing gometalinter. This is a known issue (its in the latest commit message for the relevant files). However this causes problems with using make all( #1052 )

/cc @adrianbrink
@rigelrozanski
Copy link
Contributor

The linter should really be enforcing that tendermint/lint is used too

@ValarDragon ValarDragon self-assigned this Jun 22, 2018
@ValarDragon ValarDragon mentioned this issue Jun 22, 2018
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ValarDragon ValarDragon

Labels
good first issue T: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tools: Fix makefile install scripts cosmos/cosmos-sdk
2 participants
@ValarDragon @rigelrozanski