Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate x/gov to use app wiring #12274

Closed
1 task done
Tracked by #11899
julienrbrt opened this issue Jun 15, 2022 · 3 comments
Closed
1 task done
Tracked by #11899

migrate x/gov to use app wiring #12274

julienrbrt opened this issue Jun 15, 2022 · 3 comments
Assignees

Comments

@julienrbrt
Copy link
Member

julienrbrt commented Jun 15, 2022

  • add app wiring functions in module.go
@julienrbrt
Copy link
Member Author

julienrbrt commented Jun 15, 2022

After the migration is done, please re-enable the tests that has been skipped / changed here:

#12259, #12312, #12334, #12366

Either by importing gov if that's judged acceptable or by refactoring that test.

@julienrbrt julienrbrt changed the title migrate x/gov to app wiring migrate x/gov to use app wiring Jun 15, 2022
@likhita-809
Copy link
Contributor

likhita-809 commented Jun 22, 2022

After migration is done, we need to re-enable the tests that are skipped here : #12329

@kocubinski kocubinski self-assigned this Jun 30, 2022
@julienrbrt
Copy link
Member Author

Due to #12398, the re-enabling of the tests must be done during the migrations to mock instead of this issue.
Closing as the port of gov to app wiring has been completed in #12369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants