Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: gov spec needs more details in v0.46 #12290

Closed
4 tasks
nooomski opened this issue Jun 16, 2022 · 2 comments · Fixed by #12410
Closed
4 tasks

Docs: gov spec needs more details in v0.46 #12290

nooomski opened this issue Jun 16, 2022 · 2 comments · Fixed by #12410
Assignees
@julienrbrt
Labels
T:Docs Changes and features related to documentation.

Comments

@nooomski
Copy link
Contributor

Summary

The gov docs for v0.46 are missing a few key details that can inform clients.

Problem Definition

Currently not covered:

  • Which proposals require submit-legacy-proposal
  • The fact that the gov module address is required as from_address in MsgSend and other TXs
  • Metadata length param
  • Details about metadata
    • Default length
    • That it's a string
    • That the intention is to have a URL on-chain and the metadata JSON sit offchain
    • A metadata schema

Proposal

High level information should sit under 01_concepts.md.
Everything except metadata details isn't blocked currently.
Hypha is currently working on drafting a metadata schema. Once we have this in place, we can add that information and complete the work.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@nooomski nooomski added the T:Docs Changes and features related to documentation. label Jun 16, 2022
@tac0turtle tac0turtle moved this to 📝 Todo in Cosmos-SDK Jun 16, 2022
@julienrbrt julienrbrt moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Jun 30, 2022
@julienrbrt julienrbrt mentioned this issue Jun 30, 2022
Merged
19 tasks
@julienrbrt julienrbrt moved this from 💪 In Progress to 👀 Needs Review in Cosmos-SDK Jul 6, 2022
Repository owner moved this from 👀 Needs Review to 👏 Done in Cosmos-SDK Jul 6, 2022
@nooomski
Copy link
Contributor Author

Few elements in this issue are not yet resolved. Could we keep this open until the metadata story has been resolved? Some of this is being discussed in #11301

@nooomski nooomski reopened this Jul 28, 2022
Repository owner moved this from 👏 Done to 📝 Todo in Cosmos-SDK Jul 28, 2022
@julienrbrt
Copy link
Member

This has been implemented in #13118

Repository owner moved this from 📝 Todo to 👏 Done in Cosmos-SDK Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julienrbrt julienrbrt

Labels
T:Docs Changes and features related to documentation.
Projects
Cosmos-SDK
Archived in project
Milestone
No milestone
2 participants
@julienrbrt @nooomski