fix: proposer deposit should be burned if proposal does not move into the deposit

[p0mvn]

Summary of Bug

In #12771 we introduced a min proposer deposit at submission time.

The feature was ported from osmosis-labs#296

However, we later discovered that Osmosis sdk fork differs from this repository. Osmosis burns the deposit if it does not move into the voting period but this repository returns it.

Since #12771 was a direct backport, this important difference was left out.

We should be burning the proposer deposit from submission time so that it is an effective measure against spam resistance.

Version

main branch

Steps to Reproduce

• submit the proposal and the initial deposit
• do not fulfill the deposit requirement for moving into the voting period
• observe that the deposit is returned (should be burned instead)

[alexanderbez]

I'm in favor of this 👍

[tac0turtle]

I started this a while ago but was waiting for the param migration., Need to resurrect this #11080. We will do it before the next release

ref #11057

[atheeshp]

Can this be picked up? @marbar3778

[yihuang]

I guess this need to backport to 0.46?

[alexanderbez]

I guess this need to backport to 0.46?

This would be state breaking, no? If so, we cannot really backport to 0.46

[jhernandezb]

Can this be added to 0.47? The current spam situation is just getting worse in cosmos governance.

[julienrbrt]

Can this be added to 0.47? The current spam situation is just getting worse in cosmos governance.

v0.47 is feature frozen. However, this is included https://github.com/cosmos/cosmos-sdk/blob/main/UPGRADING.md#minimum-proposal-deposit-at-time-of-submission and will probably solve that spam issue.

[jhernandezb]

I don't know why this was left out, if there is no penalty spam depositors will just get their money back even with a 20% min deposit.

[julienrbrt]

I don't know why this was left out, if there is no penalty spam depositors will just get their money back even with a 20% min deposit.

You are right!

[julienrbrt]

Superseded by #11057.
#11057 will be included in v0.47 as per community request.