-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CacheContext() writeFn should write emitted events as well #12912
Labels
Comments
This is a bug that would be really helpful if fixed. caused a bug with events in Osmosis & persistence that @puneet2019 fixed for us. |
yeah, caller site has been writing the events explicitly, not sure if there's use case that don't want to write the events, maybe add a boolean parameter to the write function? |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Calling
context.CacheContext()
and then writing thecacheContext
should emit the events from the cached context as wellProblem Definition
Calling cache context followed by writeCache() does not emit the events emitted for the cached context since a new event manager has been used for the cached context. This causes the caller to also manually emit the events
Proposal
Modify the existing
context.CacheContext()
function to return awriteCache()
function which also emits the cached events into the actual context event managerThe text was updated successfully, but these errors were encountered: