Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simapp append more add-genesis-account coins after initialization #13232

Closed
Reecepbcups opened this issue Sep 11, 2022 · 0 comments · Fixed by #13233
Closed

feat: simapp append more add-genesis-account coins after initialization #13232

Reecepbcups opened this issue Sep 11, 2022 · 0 comments · Fixed by #13233

Comments

@Reecepbcups
Copy link
Member

Reecepbcups commented Sep 11, 2022

Summary

Add the ability to add more coins (both in amount and/or in new denominations) after the initial creation of a genesis account if specified.

simd init testing
simd add-genesis-account cosmos1c5ndezk603hyr4jfrdu3t2czpzpezcqr37h9tz 100uatom
simd add-genesis-account cosmos1c5ndezk603hyr4jfrdu3t2czpzpezcqr37h9tz 50uatom --append
simd add-genesis-account cosmos1c5ndezk603hyr4jfrdu3t2czpzpezcqr37h9tz 25utoken --append

genesis file:

"balances": [
  {
    "address": "cosmos1c5ndezk603hyr4jfrdu3t2czpzpezcqr37h9tz",
    "coins": [
      {
        "denom": "uatom",
        "amount": "150"
      },
      {
        "denom": "utoken",
        "amount": "25"
      }
    ]
  }
],
"supply": [
  {
    "denom": "uatom",
    "amount": "150"
  },
  {
    "denom": "utoken",
    "amount": "25"
  }
],

Problem Definition

By adding this feature it in, it will simplify genesis creation (and airdrops) for future chains.

This allows a developer to perform airdrop logic for one or more chains, then put each into their own shell file to add the genesis accounts.
(Personally I needed this both for the eve & craft economy chains)
The current way to do this now is have 1 large script do ALL of the logic calculations every time. This reduces that complexity and makes it more modular.

Proposal

If a --append flag is given to the simd add-genesis-account sub command, add the new token to the users balance and increase the supply

PR: #13233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant