-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify apps do not need to import simapp
#13379
Comments
Let's ensure we mark this as completed for/before 0.47 cc @marbar3778 |
julienrbrt
changed the title
Verify apps do not need to import
Verify apps do not need to import Sep 26, 2022
SimApp
simapp
19 tasks
|
Yup! |
19 tasks
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This PR (#13376 ) pointed out that apps still need to import
simapp
.We should still verify that there is no other needs to import simapp and provide clear alternatives in the
UPGRADING.md
Example:
https://github.com/cosmos/gaia/blob/main/app/sim_test.go
https://github.com/CosmWasm/wasmd/blob/main/app/sim_test.go
refactor: move
simapp.App
toruntime.AppI
#13378refactor!: extract simulation helpers out of simapp #13402
The text was updated successfully, but these errors were encountered: