Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify apps do not need to import simapp #13379

Closed
2 tasks done
julienrbrt opened this issue Sep 24, 2022 · 3 comments · Fixed by #13402
Closed
2 tasks done

Verify apps do not need to import simapp #13379

julienrbrt opened this issue Sep 24, 2022 · 3 comments · Fixed by #13402
Assignees

Comments

@julienrbrt
Copy link
Member

julienrbrt commented Sep 24, 2022

This PR (#13376 ) pointed out that apps still need to import simapp.

We should still verify that there is no other needs to import simapp and provide clear alternatives in the UPGRADING.md

Example:

@alexanderbez
Copy link
Contributor

Let's ensure we mark this as completed for/before 0.47

cc @marbar3778

@julienrbrt julienrbrt changed the title Verify apps do not need to import SimApp Verify apps do not need to import simapp Sep 26, 2022
@julienrbrt julienrbrt self-assigned this Sep 27, 2022
@julienrbrt
Copy link
Member Author

julienrbrt commented Sep 27, 2022

AppStateFn is not extracted, as it is very dependent on simapp (at least on simapp/params). I think each app should have theirs, right? Osmosis has theirs, Crypto.com too f.e.

@alexanderbez
Copy link
Contributor

Yup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants