Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Textual public API #14552

Closed
4 tasks
amaury1093 opened this issue Jan 9, 2023 · 0 comments · Fixed by #14595
Closed
4 tasks

Improve Textual public API #14552

amaury1093 opened this issue Jan 9, 2023 · 0 comments · Fixed by #14595

Comments

@amaury1093
Copy link
Contributor

amaury1093 commented Jan 9, 2023 •
edited
Loading

Summary

Improve the user-facing API for SIGN_MODE_TEXTUAL.

Proposal

  • Move everything from tx/textual/valuerenderer to tx/textual, ref feat!: Add Textual SignModeHandler #13734 (comment)
  • Add a DefineMessageRenderer method to add custom message renderers
  • Define proto annotations for custom message renderers (recall: they are informative only)
  • minimize API surface if possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Improve textual's API cosmos/cosmos-sdk
1 participant
@amaury1093