New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/bank: Switch MsgSend tests to be table driven #1546

Closed

ValarDragon opened this issue Jul 4, 2018 · 1 comment · Fixed by #1764

Assignees

Labels

Contributor

ValarDragon commented Jul 4, 2018

Currently they are hardcoded and not easily extendable. These really should be table driven tests, as that is the recommended method for testing this sort of thing in golang. (https://github.com/golang/go/wiki/TableDrivenTests)

ValarDragon added the T: Tests label

Member

ebuchman commented Jul 5, 2018

Yes! Tagging #1555 as related to "simplifying tests"

alexanderbez self-assigned this

alexanderbez mentioned this issue

Table-Driven Bank Module Unit Tests #1764

Merged

8 tasks

cwgoes closed this as completed in #1764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment