Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redelegation subtracts coins from redelegator #1630

Closed
cwgoes opened this issue Jul 11, 2018 · 1 comment
Closed

Redelegation subtracts coins from redelegator #1630

cwgoes opened this issue Jul 11, 2018 · 1 comment
Assignees
@rigelrozanski
Labels
C:x/staking T:Bug

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Jul 11, 2018 •
edited
Loading

Caught by #1620 as it breaks the loose token supply invariant.

stakeKeeper.BeginRedelegation calls stakeKeeper.Delegate, which subtracts coins from the delegator's account - but stakeKeeper.unbond never adds coins to the delegator's account; it just creates a Delegation object. Probably introduced with the unbonding period changes; not sure what the easiest way to change the code structure is (maybe we need a different Delegate function for redelegation), but this definitely isn't the desired behavior.
@cwgoes cwgoes mentioned this issue Jul 11, 2018
Merged
7 tasks
@rigelrozanski
Copy link
Contributor

Oh wow - great catch

This was referenced Jul 11, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rigelrozanski rigelrozanski

Labels
C:x/staking T:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rigelrozanski @cwgoes