Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit x/genutil v0.47...v0.50 #16716

Closed
likhita-809 opened this issue Jun 27, 2023 · 2 comments · Fixed by #16818
Closed

Audit x/genutil v0.47...v0.50 #16716

likhita-809 opened this issue Jun 27, 2023 · 2 comments · Fixed by #16818
Assignees
@julienrbrt @likhita-809
Labels
C:x/genutil genutil module issues T: Audit

Comments

@likhita-809
Copy link
Contributor

No description provided.

@likhita-809 likhita-809 mentioned this issue Jun 27, 2023
Closed
52 tasks
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Jun 27, 2023
@likhita-809 likhita-809 self-assigned this Jun 27, 2023
@github-project-automation github-project-automation bot moved this to 📝 Todo in Cosmos-SDK Jun 27, 2023
@likhita-809 likhita-809 added C:x/genutil genutil module issues R:Eden and removed needs-triage Issue that needs to be triaged labels Jun 27, 2023
@likhita-809
Copy link
Contributor Author

Most of the changes looks fine. Prominently the following:

  • Customized genesis migration and usage of MigrationMap instead of hardcoded genesis migration.
  • genesis handling completely handled by application instead of CometBFT
  • now AddGenesisAccount lives in genutil module
  • and other small fixes were there

@likhita-809 likhita-809 mentioned this issue Jun 29, 2023
Merged
19 tasks
@julienrbrt julienrbrt self-assigned this Jul 3, 2023
@julienrbrt
Copy link
Member

julienrbrt commented Jul 3, 2023 •
edited
Loading

The changes look good. There is just an edge case, where an app started with a cometbft genesis and exports it, the app name and version were not being filled, as well as the version would stay the same when exporting the genesis.

@julienrbrt julienrbrt mentioned this issue Jul 3, 2023
Merged
19 tasks
@github-project-automation github-project-automation bot moved this from 📝 Todo to 👏 Done in Cosmos-SDK Jul 3, 2023
@tac0turtle tac0turtle removed this from Cosmos-SDK Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julienrbrt julienrbrt

@likhita-809 likhita-809

Labels
C:x/genutil genutil module issues T: Audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(genutil): audit cosmos/cosmos-sdk
2 participants
@julienrbrt @likhita-809