Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit runtime v0.47..v0.50 #16858

Closed
alexanderbez opened this issue Jul 6, 2023 · 6 comments · Fixed by #17037
Closed

Audit runtime v0.47..v0.50 #16858

alexanderbez opened this issue Jul 6, 2023 · 6 comments · Fixed by #17037
Assignees
@alexanderbez @julienrbrt
Labels
T: Audit

Comments

@alexanderbez
Copy link
Contributor

No description provided.

@alexanderbez alexanderbez mentioned this issue Jul 6, 2023
Closed
52 tasks
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Jul 6, 2023
@alexanderbez alexanderbez self-assigned this Jul 6, 2023
@julienrbrt julienrbrt added R:Eden T: Audit and removed needs-triage Issue that needs to be triaged labels Jul 6, 2023
@julienrbrt julienrbrt self-assigned this Jul 6, 2023
@tac0turtle
Copy link
Member

how is this audit going? need any help?

@julienrbrt
Copy link
Member

how is this audit going? need any help?

As I'm 2nd reviewer, I haven't started. I could if needed, however.

@alexanderbez alexanderbez mentioned this issue Jul 17, 2023
Merged
19 tasks
@alexanderbez
Copy link
Contributor Author

alexanderbez commented Jul 17, 2023 •
edited
Loading

Major changes observed:

  • ABCI changes to the AppI interface
  • Addition of KVStore service
  • Various service additions to module registration and injection

Minor linting changes: #17035

@julienrbrt julienrbrt mentioned this issue Jul 18, 2023
Merged
21 tasks
@julienrbrt
Copy link
Member

julienrbrt commented Jul 18, 2023 •
edited
Loading

Found nothing either major. Refactoring the placement of the address codecs to remove the dependency on sdk config in app runtime and auth/tx (#17037).

One question about the runtime event manager (#15547). Shouldn't it be more used throughout the codebase?

@julienrbrt
Copy link
Member

cc @alexanderbez about the event manager question above.

@tac0turtle
Copy link
Member

it doesnt need to be now, the goal is to adopt this throughout the repo over time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderbez alexanderbez

@julienrbrt julienrbrt

Labels
T: Audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(runtime): define address codec providers in runtime cosmos/cosmos-sdk
3 participants
@alexanderbez @tac0turtle @julienrbrt