Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all state machine parameters are in genesis #1704

Closed
4 tasks
cwgoes opened this issue Jul 17, 2018 · 1 comment · Fixed by #2232
Closed
4 tasks

Ensure all state machine parameters are in genesis #1704

cwgoes opened this issue Jul 17, 2018 · 1 comment · Fixed by #2232
Assignees
@mossid

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Jul 17, 2018 •
edited
Loading

We can keep client DoS prevention parameters as constants in Golang source files, but anything state-machine-related should be in genesis; it's more idiomatic (e.g. allows implementations in other languages more easily) and makes changing the parameters easier.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@cwgoes cwgoes mentioned this issue Jul 17, 2018
Closed
8 tasks
@mossid mossid self-assigned this Jul 18, 2018
This was referenced Jul 19, 2018
Closed
Closed
@ValarDragon ValarDragon mentioned this issue Sep 4, 2018
Closed
4 tasks
@ValarDragon
Copy link
Contributor

Closing in favor of #2229.

@mossid mossid mentioned this issue Sep 4, 2018
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mossid mossid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

R4R: Paramstore Refactor Base cosmos/cosmos-sdk
3 participants
@ValarDragon @mossid @cwgoes