Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genesis: Panic if there is a duplicate validator #1708

Closed
2 of 4 tasks
ValarDragon opened this issue Jul 17, 2018 · 3 comments
Closed
2 of 4 tasks

genesis: Panic if there is a duplicate validator #1708

ValarDragon opened this issue Jul 17, 2018 · 3 comments

Comments

@ValarDragon
Copy link
Contributor

I believe that the behavior for a duplicate validator is undefined. We should panic / error if there are two identical validator addresses in the genesis file. (This is inspired by the latest testnet)


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ValarDragon ValarDragon changed the title genesis: Panic if a duplicate validator genesis: Panic if there is a duplicate validator Jul 17, 2018
@rigelrozanski
Copy link
Contributor

I don't think we need to panic, we should definitely error and halt the genesis however

@rigelrozanski
Copy link
Contributor

In a way all sorts of bad genesis is expected user input - so we should expect errors, it's not unexpected code behaviour to have two identical validators in the genesis file so shouldn't panic

@ValarDragon ValarDragon mentioned this issue Sep 4, 2018
4 tasks
@ValarDragon
Copy link
Contributor Author

Closing in favor of #2229.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants