Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collections): do not error when iterating an empty collection #17289

Closed
testinginprod opened this issue Aug 4, 2023 · 2 comments · Fixed by #17290
Closed

feat(collections): do not error when iterating an empty collection #17289

testinginprod opened this issue Aug 4, 2023 · 2 comments · Fixed by #17290

Comments

@testinginprod
Copy link
Contributor

collections errors when we try to iterate (or walk as a consequence) an empty collection.

We decided that iterating an empty collection is not an issue, so the iterating APIs should error only when the query is invalid, for example when the start key is bigger than the end key of a range.

@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Aug 4, 2023
@testinginprod testinginprod added C:collections and removed needs-triage Issue that needs to be triaged labels Aug 4, 2023
@github-project-automation github-project-automation bot moved this to 📝 Todo in Cosmos-SDK Aug 4, 2023
@github-project-automation github-project-automation bot moved this from 📝 Todo to 👏 Done in Cosmos-SDK Aug 7, 2023
@julienrbrt
Copy link
Member

I think we should create another issue for someone to clean it up in the SDK on all modules.

@testinginprod
Copy link
Contributor Author

#17310 @julienrbrt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants