Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: Make all binaries use tagged versions #1809

Closed
1 of 4 tasks
ValarDragon opened this issue Jul 24, 2018 · 0 comments · Fixed by #2464
Closed
1 of 4 tasks

tools: Make all binaries use tagged versions #1809

ValarDragon opened this issue Jul 24, 2018 · 0 comments · Fixed by #2464
Labels
good first issue help wanted

Comments

@ValarDragon
Copy link
Contributor

ValarDragon commented Jul 24, 2018 •
edited
Loading

Summary

Per discussion with @ebuchman, we should be using tagged versions (if existent) for all binary tools we use. (e.g. dep, linters)

Problem Definition

Currently we use the default branch for the various repos we use. However alot of people use their master as we use develop.

Proposal

Enforce the installed version in the make files.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ValarDragon ValarDragon mentioned this issue Oct 10, 2018
Merged
4 tasks
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this issue Mar 1, 2024
@glnro @okwme
chore: rho upgrade handler (cosmos#1809)
912a231 
* Add upgrade config for globalfee

* fix: globalfee init module

* fix: set globalfee params in initModule

* Configure upgrade handler for rho

* Remove metadata

* Fix import order

* Update app/upgrades/v8/upgrades.go

Co-authored-by: Yaru Wang <yaru@interchain.io>
Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lock binary dependencies to a specific commits / versions cosmos/cosmos-sdk
1 participant
@ValarDragon