Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: possible autocli codec error #18256

Closed
1 task done
chatton opened this issue Oct 25, 2023 · 0 comments
Closed
1 task done

[Bug]: possible autocli codec error #18256

chatton opened this issue Oct 25, 2023 · 0 comments
Assignees
Labels

Comments

@chatton
Copy link
Contributor

chatton commented Oct 25, 2023

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

When working on E2E tests, we noticed that after a governance proposal has been submitted including an Any via govv1 arbitrary message execution.

Everything works as expected, and the proposal is written to state.

However, when a CLI query is made simd q gov proposals I saw the following error

cannot marshal response

// Ommitting the majority of the fields


\\xc4\\x16]*$lͷg\\x13\\x9f\\xd9\\xc4\\xed\\xfd\\x85\\x87)\\xb7ozptd˦\\x8d\\xbf\\x17$\\xec\\xe7\\x8c\\xcdT\\x98\\x89Xjg7\\xf8\\xd4\\xfe\\xce\\xf7@o\\x98}\\xad7\\xccV\\xf5\\x86\\xd9\\xdc\\xde0ӽa\\xb6\\xe8oϜa\\xbed\\xed\\xeco>u\\xb3\\xc7\\xfa\\xd9\\xe3\\xd2\\xfa0\\x1b\\xac\\x0f\\xffw\\x00\\x00\\x00\\xff\\xff\\xa5\\x1a\\\"\\x012o\\x0c\\x00\"} status:PROPOSAL_STATUS_VOTING_PERIOD final_tally_result:{yes_count:\"0\" abstain_count:\"0\" no_count:\"0\" no_with_veto_count:\"0\"} submit_time:{seconds:1698057688 nanos:23849290} deposit_end_time:{seconds:1698057698 nanos:23849290} total_deposit:{denom:\"stake\" amount:\"500000000\"} voting_start_time:{seconds:1698057688 nanos:23849290} voting_end_time:{seconds:1698144088 nanos:23849290} metadata:\"none\" title:\"Grandpa Contract\" summary:\"new grandpa contract\" proposer:\"cosmos1elwch8vtgpssxw87ycvvlw4jar0pmeyuh6ayey\" expedited:true}: proto: google.protobuf.Any: unable to resolve \"/ibc.lightclients.wasm.v1.MsgStoreCode\": not found"

proto: google.protobuf.Any: unable to resolve \"/ibc.lightclients.wasm.v1.MsgStoreCode\": not found"

It appears as if this is happening here.

After some debugging it looks like the decoding is failing in the CLI query params, but succeeding no problem but succeeds when accessing the Proposals map e.g. here

The temporary workaround we ended up using was to query the proposal state using the gRPC endpoints directly (not using the cli)

With this, the test which executes a gov proposal, votes on it and queries it passes.

The simapp in question is this one.

There was also another report the same issue happening on slack. This occurred when querying a gov proposal via CLI. This was on 0.50-r0 (simapp from ibc-go)

ERR failure when running app err="cannot marshal response proposals:{id:1 messages:{type_url:\"/ibc.core.channel.v1.MsgChannelUpgradeInit\" value:\"\\n\\x08transfer\\x12\\tchannel-0\\x1aC\\x08\\x01\\x12\\x0cconnection-0\\x1a1{\\\"app_version\\\":\\\"ics20-1\\\",\\\"fee_version\\\":\\\"ics29-1\\\"}\\\"-cosmos10d07y265gmmuvt4z0w9aw880jnsr700j6zn9kn\"} status:PROPOSAL_STATUS_VOTING_PERIOD final_tally_result:{yes_count:\"0\" abstain_count:\"0\" no_count:\"0\" no_with_veto_count:\"0\"} submit_time:{seconds:1698240004 nanos:997149000} deposit_end_time:{seconds:1698240014 nanos:997149000} total_deposit:{denom:\"stake\" amount:\"10000001\"} voting_start_time:{seconds:1698240004 nanos:997149000} voting_end_time:{seconds:1698240014 nanos:997149000} title:\"Channel upgrade\" summary:\"Upgrade channel version\" proposer:\"cosmos1a3adywpjydjwjf6d3qm9t3em3pp84arwvs9tkv\"} pagination:{total:1}: proto:\u00a0google.protobuf.Any: unable to resolve \"/ibc.core.channel.v1.MsgChannelUpgradeInit\": not found"

cc @julienrbrt

Cosmos SDK Version

0.50-rc1 & 0.50-rc0

How to reproduce?

Submit a gov proposal with an any.

Query the proposals: simd q gov proposals

@chatton chatton added the T:Bug label Oct 25, 2023
@julienrbrt julienrbrt self-assigned this Oct 25, 2023
@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Oct 25, 2023
@julienrbrt julienrbrt moved this from 👀 To Do to ✍ In Progress in Cosmos-SDK Oct 30, 2023
@github-project-automation github-project-automation bot moved this from ✍ In Progress to 🥳 Done in Cosmos-SDK Nov 3, 2023
@tac0turtle tac0turtle removed this from Cosmos-SDK Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants