Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bond intra-tx counter not correctly set on stake.InitGenesis #1839

Closed
cwgoes opened this issue Jul 26, 2018 · 2 comments
Closed

Bond intra-tx counter not correctly set on stake.InitGenesis #1839

cwgoes opened this issue Jul 26, 2018 · 2 comments
Labels
C:x/staking

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Jul 26, 2018 •
edited
Loading

Caught on https://github.com/cosmos/cosmos-sdk/tree/8cacb9658402d7c800e24e3f9f93f7d9576a1d75, will write an isolating testcase.

edit: Finally traced to an error with stake genesis initialization. Bond intra-tx counter was set correctly for the power store record but not for the validator record, so when we wrote a new power store record later we left the old record in when we should have deleted it.
@cwgoes cwgoes mentioned this issue Jul 26, 2018
Merged
15 tasks
@ValarDragon
Copy link
Contributor

Can the resolution for this issue be made as a separate PR onto the simulation PR

@cwgoes
Copy link
Contributor Author

cwgoes commented Jul 26, 2018

Can the resolution for this issue be made as a separate PR onto the simulation PR

Maybe, I think it depends on the resolution of the issue.

@cwgoes cwgoes changed the title Staking can enter a state where we bond a validator but the cliff validator doesn't change Staking can enter a state where we bond a validator in UpdateValidators but the cliff validator doesn't change Jul 26, 2018
@cwgoes cwgoes changed the title Staking can enter a state where we bond a validator in UpdateValidators but the cliff validator doesn't change Bond intra-tx counter not correctly set on stake.InitGenesis Jul 27, 2018
@cwgoes cwgoes mentioned this issue Jul 27, 2018
Merged
9 tasks
@cwgoes cwgoes mentioned this issue Jul 29, 2018
Closed
@cwgoes cwgoes mentioned this issue Aug 10, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:x/staking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ValarDragon @cwgoes