Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support display mnemonic discreetly for keys add #18662

Closed
Halimao opened this issue Dec 8, 2023 · 0 comments · Fixed by #18663
Closed

[Feature]: Support display mnemonic discreetly for keys add #18662

Halimao opened this issue Dec 8, 2023 · 0 comments · Fixed by #18663

Comments

@Halimao
Copy link
Contributor

Halimao commented Dec 8, 2023

Summary

simd keys add name will show mnemonic in output, we can show it discreetly on an alternate screen.

Problem Definition

As the default behaviour of simd keys add name will show the mnemonic, it would be more safe if we display mnemonic on an alternate screen, even through mnemonic print could be disabled by --no-backup.

Proposed Feature

After we run simd keys add test, the mnemonic will show on an alternate screen, with some prompt msg. With 'Enter' key press, will bring user back to original screen, and show the key info.

image

image

@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Dec 8, 2023
@Halimao Halimao changed the title [Feature]: Support display mnemonic discreetly [Feature]: Support display mnemonic discreetly for keys add Dec 9, 2023
@github-project-automation github-project-automation bot moved this from 👀 To Do to 🥳 Done in Cosmos-SDK Dec 11, 2023
@tac0turtle tac0turtle removed this from Cosmos-SDK Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant