Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: v0.50.2 upgrade #18733

Closed
1 task done
RaulBernal opened this issue Dec 13, 2023 · 2 comments
Closed
1 task done

[Bug]: v0.50.2 upgrade #18733

RaulBernal opened this issue Dec 13, 2023 · 2 comments
Assignees
@facundomedica

Comments

@RaulBernal
Copy link

RaulBernal commented Dec 13, 2023 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

Upgrading from v0.47 to v0.50.2 I found this issue related in https://github.com/cosmos/cosmos-sdk/pull/18577/files & #18644 BUT it persist after the upgrade.

Along the upgrade, we could see this messages twice:

10:49PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
10:49PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server

After upgrade and the adding of the new modules, when normal activity is back, the general consensus is:

11:06PM INF received proposal module=consensus proposal="Proposal{301423/0 (2367B1C1D63FDCCF8D8DF6B984A3F3A59642035923E9DC9CFCFA88770A97CB72:1:F4A8FAC433DB, -1) 0135A4C6F6F3 @ 2023-12-12T22:06:28.753343485Z}" proposer=0D61B4BFACE772DA88066EE065B807F0268DDC7D
11:06PM INF received complete proposal block hash=2367B1C1D63FDCCF8D8DF6B984A3F3A59642035923E9DC9CFCFA88770A97CB72 height=301423 module=consensus
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM INF finalizing commit of block hash=2367B1C1D63FDCCF8D8DF6B984A3F3A59642035923E9DC9CFCFA88770A97CB72 height=301423 module=consensus num_txs=0 root=33EA35E1D4968B0855C76EABDBA73F24129839541B94B8F10EE1590BAF689353
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM INF finalized block block_app_hash=028EBE4383391C805BCF6D7F2F2E81A23EBFDF5FE092692F54A5C43B67C74E50 height=301423 module=state num_txs_res=0 num_val_updates=0
11:06PM INF executed block app_hash=028EBE4383391C805BCF6D7F2F2E81A23EBFDF5FE092692F54A5C43B67C74E50 height=301423 module=state
11:06PM INF committed state block_app_hash=33EA35E1D4968B0855C76EABDBA73F24129839541B94B8F10EE1590BAF689353 height=301423 module=state
11:06PM INF indexed block events height=301423 module=txindex
11:06PM INF Ensure peers module=pex numDialing=0 numInPeers=1 numOutPeers=0 numToDial=40
11:06PM INF We need more addresses. Sending pexRequest to random peer module=pex peer="Peer{MConn{212.227.151.105:47504} 85be53f499c803a10e73734018334049a7c4686d in}"
11:06PM INF Timed out dur=4982.029548 height=301424 module=consensus round=0 step=RoundStepNewHeight
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM INF received proposal module=consensus proposal="Proposal{301424/0 (20314C2495B96040CF9FECF081452B00A28A54762C1424934E4D74A0FB674405:1:6F1A8AA956C5, -1) 47CCA6D298D0 @ 2023-12-12T22:06:34.075488952Z}" proposer=3332A1D571F4F0489C4168A9075DA71F1A764945
11:06PM INF received complete proposal block hash=20314C2495B96040CF9FECF081452B00A28A54762C1424934E4D74A0FB674405 height=301424 module=consensus
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM INF finalizing commit of block hash=20314C2495B96040CF9FECF081452B00A28A54762C1424934E4D74A0FB674405 height=301424 module=consensus num_txs=0 root=028EBE4383391C805BCF6D7F2F2E81A23EBFDF5FE092692F54A5C43B67C74E50
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM INF finalized block block_app_hash=DBA047C662AC6211CA595F7BE13B34F1BCA91EC899F05961DA44C4E542407B78 height=301424 module=state num_txs_res=0 num_val_updates=0

So first thoughts discussing the issue with @julienrbrt are about that Baseapp keeps not finding consensus params, so upgrade should set them and them are not saved.

Full upgrade log:

build/bcnad start 
10:56PM INF Upgrading IAVL storage for faster queries + execution on live state. This may take a while commit=436F6D6D697449447B5B5D3A307D module=server store_key="KVStoreKey{0xc000ee7b20, circuit}" version=301420
10:56PM INF Upgrading IAVL storage for faster queries + execution on live state. This may take a while commit=436F6D6D697449447B5B5D3A307D module=server store_key="KVStoreKey{0xc0014d9d60, feeibc}" version=301420
10:56PM INF starting node with ABCI CometBFT in-process module=server
10:56PM INF service start impl=multiAppConn module=proxy msg="Starting multiAppConn service"
10:56PM INF service start connection=query impl=localClient module=abci-client msg="Starting localClient service"
10:56PM INF service start connection=snapshot impl=localClient module=abci-client msg="Starting localClient service"
10:56PM INF service start connection=mempool impl=localClient module=abci-client msg="Starting localClient service"
10:56PM INF service start connection=consensus impl=localClient module=abci-client msg="Starting localClient service"
10:56PM INF service start impl=EventBus module=events msg="Starting EventBus service"
10:56PM INF service start impl=PubSub module=pubsub msg="Starting PubSub service"
10:56PM INF service start impl=IndexerService module=txindex msg="Starting IndexerService service"
10:56PM INF ABCI Handshake App Info hash=9E799ADA1B7F924CE523D858006AE1249CE6D07096426BD563AC650CACFCB2E4 height=301419 module=consensus protocol-version=0 software-version=main-873185552597375a6c3354bc852466c72804c923
10:56PM INF ABCI Replay Blocks appHeight=301419 module=consensus stateHeight=301419 storeHeight=301420
10:56PM INF Replay last block using real app module=consensus
10:56PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
10:56PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
10:56PM INF applying upgrade "StickyFingers" at height: 301420 module=x/upgrade
10:56PM INF Cosmos-SDK v0.50.x is here... module=server
10:56PM INF Module: vesting, Version: 1 module=server
10:56PM INF Module: consensus, Version: 1 module=server
10:56PM INF Module: gov, Version: 4 module=server
10:56PM INF Module: slashing, Version: 3 module=server
10:56PM INF Module: staking, Version: 4 module=server
10:56PM INF Module: upgrade, Version: 2 module=server
10:56PM INF Module: mint, Version: 2 module=server
10:56PM INF Module: auth, Version: 4 module=server
10:56PM INF Module: distribution, Version: 3 module=server
10:56PM INF Module: evidence, Version: 1 module=server
10:56PM INF Module: genutil, Version: 1 module=server
10:56PM INF Module: ibc, Version: 4 module=server
10:56PM INF Module: transfer, Version: 3 module=server
10:56PM INF Module: authz, Version: 2 module=server
10:56PM INF Module: bank, Version: 4 module=server
10:56PM INF Module: bcna, Version: 1 module=server
10:56PM INF Module: capability, Version: 1 module=server
10:56PM INF Module: feegrant, Version: 2 module=server
10:56PM INF Module: crisis, Version: 2 module=server
10:56PM INF Module: group, Version: 2 module=server
10:56PM INF Module: interchainaccounts, Version: 2 module=server
10:56PM INF Module: params, Version: 1 module=server
10:56PM INF adding a new module: 06-solomachine module=server
10:56PM INF adding a new module: 07-tendermint module=server
10:56PM INF adding a new module: circuit module=server
10:56PM INF adding a new module: feeibc module=server
10:56PM INF migrating module gov from version 4 to version 5 module=server
10:56PM INF migrating module ibc from version 4 to version 5 module=server
10:56PM INF successfully migrated client to self-manage params module=x/ibc/client
10:56PM INF successfully migrated connection to self-manage params module=x/ibc/connection
10:56PM INF migrating module interchainaccounts from version 2 to version 3 module=server
10:56PM INF successfully migrated ica/host submodule to self-manage params module=x/ibc-interchainaccounts
10:56PM INF successfully migrated ica/controller submodule to self-manage params module=x/ibc-interchainaccounts
10:56PM INF adding a new module: runtime module=server
10:56PM INF migrating module slashing from version 3 to version 4 module=server
10:56PM INF migrating module staking from version 4 to version 5 module=server
10:56PM INF migrating module transfer from version 3 to version 4 module=server
10:56PM INF successfully migrated transfer app self-manage params module=x/ibc-transfer
10:56PM INF migrating module transfer from version 4 to version 5 module=server
10:56PM INF successfully added metadata to IBC voucher denominations module=x/ibc-transfer
10:56PM INF migrating module auth from version 4 to version 5 module=server
10:56PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
10:56PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
10:56PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
10:56PM INF finalized block block_app_hash=7A7CFA4E1D33FF3F94A390B120A4EC850ADD8C020D99B3314906F98F0BA24800 height=301420 module=consensus num_txs_res=0 num_val_updates=0
10:56PM INF executed block app_hash=7A7CFA4E1D33FF3F94A390B120A4EC850ADD8C020D99B3314906F98F0BA24800 height=301420 module=consensus
10:56PM INF committed state block_app_hash=9E799ADA1B7F924CE523D858006AE1249CE6D07096426BD563AC650CACFCB2E4 height=301420 module=consensus
10:56PM INF Completed ABCI Handshake - CometBFT and App are synced appHash=7A7CFA4E1D33FF3F94A390B120A4EC850ADD8C020D99B3314906F98F0BA24800 appHeight=301419 module=consensus
10:56PM INF Version info abci=2.0.0 block=11 commit_hash= module=server p2p=8 tendermint_version=0.38.2
10:56PM INF This node is a validator addr=3332A1D571F4F0489C4168A9075DA71F1A764945 module=consensus pubKey=PubKeyEd25519{4975463257214EA7DB6ED9265B554D4B745C5AFEE23908E5FC574FBAFA84F393}
10:56PM INF indexed block events height=301420 module=txindex
10:56PM INF P2P Node ID ID=bee4c8fcb34d9e2521f4e30803bd83f3ce90f80d file=/home/raul/.bcna/config/node_key.json module=p2p
10:56PM INF Adding persistent peers addrs=[] module=p2p
10:56PM INF Adding unconditional peer ids ids=[] module=p2p
10:56PM INF Add our address to book addr=bee4c8fcb34d9e2521f4e30803bd83f3ce90f80d@0.0.0.0:26656 book=/home/raul/.bcna/config/addrbook.json module=p2p
10:56PM INF service start impl=Node module=server msg="Starting Node service"
10:56PM INF serve module=rpc-server msg="Starting RPC HTTP server on [::]:26657"
10:56PM INF service start impl="P2P Switch" module=p2p msg="Starting P2P Switch service"
10:56PM INF service start impl=Mempool module=mempool msg="Starting Mempool service"
10:56PM INF service start impl=Reactor module=blocksync msg="Starting Reactor service"
10:56PM INF service start impl=BlockPool module=blocksync msg="Starting BlockPool service"
10:56PM INF service start impl=ConsensusReactor module=consensus msg="Starting Consensus service"
10:56PM INF Reactor  module=consensus waitSync=true
10:56PM INF service start impl=Evidence module=evidence msg="Starting Evidence service"
10:56PM INF service start impl=StateSync module=statesync msg="Starting StateSync service"
10:56PM INF service start impl=PEX module=pex msg="Starting PEX service"
10:56PM INF service start book=/home/raul/.bcna/config/addrbook.json impl=AddrBook module=p2p msg="Starting AddrBook service"
10:56PM INF Ensure peers module=pex numDialing=0 numInPeers=0 numOutPeers=0 numToDial=40
10:56PM INF Saving AddrBook to file book=/home/raul/.bcna/config/addrbook.json module=p2p size=1
10:56PM INF Inbound Peer rejected err="filtered CONN<164.68.119.233:47598>: duplicate CONN<164.68.119.233:47598>" module=p2p numPeers=0
10:56PM INF starting gRPC server... address=0.0.0.0:9090 module=grpc-server
10:56PM INF starting API server... address=tcp://0.0.0.0:1317 module=api-server
10:56PM INF serve module=api-server msg="Starting RPC HTTP server on [::]:1317"
10:56PM INF Ensure peers module=pex numDialing=0 numInPeers=0 numOutPeers=0 numToDial=40
10:56PM INF Inbound Peer rejected err="auth failure: handshake failed: EOF" module=p2p numPeers=0
..... looking for peers...
11:06PM INF Ensure peers module=pex numDialing=0 numInPeers=0 numOutPeers=0 numToDial=40
11:06PM INF Inbound Peer rejected err="auth failure: secret conn failed: EOF" module=p2p numPeers=0
11:06PM INF service start impl="Peer{MConn{212.227.151.105:47504} 85be53f499c803a10e73734018334049a7c4686d in}" module=p2p msg="Starting Peer service" peer=85be53f499c803a10e73734018334049a7c4686d@212.227.151.105:47504
11:06PM INF service start impl=MConn{212.227.151.105:47504} module=p2p msg="Starting MConnection service" peer=85be53f499c803a10e73734018334049a7c4686d@212.227.151.105:47504
11:06PM INF Time to switch to consensus reactor! height=301421 module=blocksync
11:06PM INF service stop impl=BlockPool module=blocksync msg="Stopping BlockPool service"
11:06PM INF SwitchToConsensus module=consensus
11:06PM INF service start impl=ConsensusState module=consensus msg="Starting State service"
11:06PM INF service start impl=baseWAL module=consensus msg="Starting baseWAL service" wal=/home/raul/.bcna/data/cs.wal/wal
11:06PM INF service start impl=Group module=consensus msg="Starting Group service" wal=/home/raul/.bcna/data/cs.wal/wal
11:06PM INF service start impl=TimeoutTicker module=consensus msg="Starting TimeoutTicker service"
11:06PM INF Searching for height height=301421 max=397 min=313 module=consensus wal=/home/raul/.bcna/data/cs.wal/wal
11:06PM INF Searching for height height=301420 max=397 min=313 module=consensus wal=/home/raul/.bcna/data/cs.wal/wal
11:06PM INF Found height=301420 index=397 module=consensus wal=/home/raul/.bcna/data/cs.wal/wal
11:06PM INF Catchup by replaying consensus messages height=301421 module=consensus
11:06PM INF Replay: Done module=consensus
11:06PM INF Timed out dur=-485109.750975 height=301421 module=consensus round=0 step=RoundStepNewHeight
11:06PM INF Timed out dur=3000 height=301421 module=consensus round=0 step=RoundStepPropose
11:06PM INF received proposal module=consensus proposal="Proposal{301421/0 (8BE734B963316F5EF1F4ED4C5AF5C26E6A4352AED2CA81B6126FBAB56D93C06A:1:A34EEFBD9993, -1) 3D2062ADADD8 @ 2023-12-12T22:06:15.859709Z}" proposer=0D61B4BFACE772DA88066EE065B807F0268DDC7D
11:06PM INF received complete proposal block hash=8BE734B963316F5EF1F4ED4C5AF5C26E6A4352AED2CA81B6126FBAB56D93C06A height=301421 module=consensus
11:06PM INF Timed out dur=1000 height=301421 module=consensus round=0 step=RoundStepPrevoteWait
11:06PM INF Timed out dur=1000 height=301421 module=consensus round=0 step=RoundStepPrecommitWait
11:06PM INF resetting proposal info height=301421 module=consensus proposer=3332A1D571F4F0489C4168A9075DA71F1A764945 round=1
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM INF received proposal module=consensus proposal="Proposal{301421/1 (F9D9BF0CF810CFA3AD03F2B93232A9CC50329DC1C105C6601D356FCC691A51F0:1:B5797CF30535, -1) 9DC8C780A029 @ 2023-12-12T22:06:17.976643206Z}" proposer=3332A1D571F4F0489C4168A9075DA71F1A764945
11:06PM INF received complete proposal block hash=F9D9BF0CF810CFA3AD03F2B93232A9CC50329DC1C105C6601D356FCC691A51F0 height=301421 module=consensus
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM INF finalizing commit of block hash=F9D9BF0CF810CFA3AD03F2B93232A9CC50329DC1C105C6601D356FCC691A51F0 height=301421 module=consensus num_txs=0 root=7A7CFA4E1D33FF3F94A390B120A4EC850ADD8C020D99B3314906F98F0BA24800
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM INF finalized block block_app_hash=F37FEFFD44719CF1687B964FF225F1AE0D81695C454CBA204EB98CAC043E179B height=301421 module=state num_txs_res=0 num_val_updates=0
11:06PM INF executed block app_hash=F37FEFFD44719CF1687B964FF225F1AE0D81695C454CBA204EB98CAC043E179B height=301421 module=state
11:06PM INF committed state block_app_hash=7A7CFA4E1D33FF3F94A390B120A4EC850ADD8C020D99B3314906F98F0BA24800 height=301421 module=state
11:06PM INF indexed block events height=301421 module=txindex
11:06PM INF Timed out dur=4977.304089 height=301422 module=consensus round=0 step=RoundStepNewHeight
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM INF received proposal module=consensus proposal="Proposal{301422/0 (A8EF69D66535E7940DCD078C6A39EB5312B51ACC1CF4F816B2618ED8A697527E:1:251D259BAA6F, -1) 181599A7B5A8 @ 2023-12-12T22:06:23.445034629Z}" proposer=3332A1D571F4F0489C4168A9075DA71F1A764945
11:06PM INF received complete proposal block hash=A8EF69D66535E7940DCD078C6A39EB5312B51ACC1CF4F816B2618ED8A697527E height=301422 module=consensus
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM INF finalizing commit of block hash=A8EF69D66535E7940DCD078C6A39EB5312B51ACC1CF4F816B2618ED8A697527E height=301422 module=consensus num_txs=0 root=F37FEFFD44719CF1687B964FF225F1AE0D81695C454CBA204EB98CAC043E179B
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM INF finalized block block_app_hash=33EA35E1D4968B0855C76EABDBA73F24129839541B94B8F10EE1590BAF689353 height=301422 module=state num_txs_res=0 num_val_updates=0
11:06PM INF executed block app_hash=33EA35E1D4968B0855C76EABDBA73F24129839541B94B8F10EE1590BAF689353 height=301422 module=state
11:06PM INF committed state block_app_hash=F37FEFFD44719CF1687B964FF225F1AE0D81695C454CBA204EB98CAC043E179B height=301422 module=state
11:06PM INF indexed block events height=301422 module=txindex
11:06PM INF Timed out dur=4977.095803 height=301423 module=consensus round=0 step=RoundStepNewHeight
11:06PM INF received proposal module=consensus proposal="Proposal{301423/0 (2367B1C1D63FDCCF8D8DF6B984A3F3A59642035923E9DC9CFCFA88770A97CB72:1:F4A8FAC433DB, -1) 0135A4C6F6F3 @ 2023-12-12T22:06:28.753343485Z}" proposer=0D61B4BFACE772DA88066EE065B807F0268DDC7D
11:06PM INF received complete proposal block hash=2367B1C1D63FDCCF8D8DF6B984A3F3A59642035923E9DC9CFCFA88770A97CB72 height=301423 module=consensus
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM INF finalizing commit of block hash=2367B1C1D63FDCCF8D8DF6B984A3F3A59642035923E9DC9CFCFA88770A97CB72 height=301423 module=consensus num_txs=0 root=33EA35E1D4968B0855C76EABDBA73F24129839541B94B8F10EE1590BAF689353
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM ERR failed to get consensus params err="collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/tendermint.types.ConsensusParams" module=server
11:06PM INF finalized block block_app_hash=028EBE4383391C805BCF6D7F2F2E81A23EBFDF5FE092692F54A5C43B67C74E50 height=301423 module=state num_txs_res=0 num_val_updates=0
11:06PM INF executed block app_hash=028EBE4383391C805BCF6D7F2F2E81A23EBFDF5FE092692F54A5C43B67C74E50 height=301423 module=state

Cosmos SDK Version

v0.50.2

How to reproduce?

For more context; the previous upgrade was completed as recommended:

v0.46 -> v0.47 upgrade was successful and new module consensus was added and migrated the params:
image
https://github.com/BitCannaGlobal/bcna/blob/BCNA-v3-way-(sdk-v0.47)/app/upgrades.go#L123

For to reproduce it:

  1. With this release, (v0.47.5) send a software-upgrade proposal:
    https://github.com/BitCannaGlobal/bcna/blob/BCNA-v3-way-(sdk-v0.47) (v3.0.0-rc3)
  2. When the upgrade height is there replace the binary with this new v0.50.2 (new Ignite build with app.go-v2)

https://github.com/BitCannaGlobal/bcna-ignite/blob/main/app/app_config.go#L162
https://github.com/BitCannaGlobal/bcna-ignite/blob/main/app/upgrades.go
@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Dec 13, 2023
@facundomedica facundomedica self-assigned this Dec 13, 2023
@facundomedica
Copy link
Member

Hey! So the issue seems to be that you've migrated the params but to the wrong store key: https://github.com/BitCannaGlobal/bcna/blob/BCNA-v3-way-(sdk-v0.47)/app/app.go#L347

To solve it, in the upgrade handler you need to create a new consensus params keeper using the wrong key again and move the data into the consensus params keeper with the right key. I've tried this and seems to work fine:

			storesvc := runtime.NewKVStoreService(app.GetKey("upgrade"))
			consensuskeeper := consensuskeeper.NewKeeper(
				app.appCodec,
				storesvc,
				app.AccountKeeper.GetAuthority(),
				runtime.EventService{},
			)

			params, err := consensuskeeper.ParamsStore.Get(ctx)
			if err != nil {
				return nil, err
			}

			err = app.ConsensusParamsKeeper.ParamsStore.Set(ctx, params)
			if err != nil {
				return nil, err
			}

@github-project-automation github-project-automation bot moved this from 👀 To Do to 🥳 Done in Cosmos-SDK Dec 13, 2023
@RaulBernal
Copy link
Author

Thanks a lot 🙏 @facundomedica, what a missing! that v0.47 branch is not (yet) in production, so we are able to fix it in origin before v.050 comes.

@RaulBernal RaulBernal mentioned this issue Feb 14, 2024
Closed
1 task
@tac0turtle tac0turtle removed this from Cosmos-SDK Feb 29, 2024
@taariq taariq mentioned this issue Apr 17, 2024
Closed
1 task
@QuocThi QuocThi mentioned this issue Apr 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@facundomedica facundomedica

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RaulBernal @facundomedica