[Feature]: Replace ABCIMessageLogs .String() method with faster JSON library

[ValarDragon]

Summary

ABCIMessageLogs.String() uses legacy amino for JSON marshalling. As far as I can tell, this usage is fully compatible with the stdlib.

We see this method is taking a surprising amount of time on Osmosis. Its taking about 2% of the state execution time during block sync.

cosmos-sdk/types/result.go

Lines 45 to 56 in 77b2366

	// String implements the fmt.Stringer interface for the ABCIMessageLogs type.
	func (logs ABCIMessageLogs) String() (str string) {
	if logs != nil {
	cdc := codec.NewLegacyAmino()
	raw, err := cdc.MarshalJSON(logs)
	if err == nil {
	str = string(raw)
	}
	}
	return str
	}

Can we replace this method with a faster, standard JSON marshalling library? I am making an issue instead of a PR just to sanity check this is integrator compatible. I don't see a way it wouldn't be compatible, but this does seem bad to break

Problem Definition

This is taking too much CPU time

Proposed Feature

Replace amino JSON marshalling here with a faster JSON marshalling library.

[alexanderbez]

As long as it's compatible with stdlib JSON, I think it should be OK and state compatible. In such a case, we can consider https://github.com/sugawarayuuta/sonnet

[tac0turtle]

there are somethings that will change, mainly because amino is protobuf style json which is not normal json. the changes are minimal and probably better in terms of ux since people dont use this with protobuf but normal json decoders/encoders

[ValarDragon]

ABCI Message Logs is a slice of ABCIMessage , which itself is a struct of just various nested strings (and one uint): https://github.com/cosmos/cosmos-sdk/blob/main/proto/cosmos/base/abci/v1beta1/abci.proto#L53-L79

A bit surprised theres even an incompatability!

[ValarDragon]

For large txs during block sync with big events, were actually seeing this take 15% of the state machine execution time! (Defined as deliverTx/Beginblock/ENdblock time measured in a blocksync pprof of state.execBlockOnProxyApp )

[alexanderbez]

I'm glad you're really benchmarking various aspects of the module codebase that have largely remained untouched for a long time.

Do you have a recommendation for an alternative JSON library?

[ValarDragon]

The standard library for now would make this much faster! In the future, sometime compiled would be great, as this structure is super simple -- but no need to complicate it for now!

Glad the speed investigations are appreciated! Was feeling really committed to improving state machine sync speeds! And then we keep facing issues on Osmosis that are related, so its becoming more and more of a priority haha.

The hot loop of looking at CPU profiles and making stuff go away is really nice though :)

Tons of wins are actually already in SDK main / the new store work as well, which is super exciting!

[alexanderbez]

Cool! Ok, so I think let's just convert this to using stdlib JSON then.