R4R: tallyResults added to state #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnya97
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #1914 +/- ##
===========================================
+ Coverage 63.55% 63.67% +0.12%
===========================================
Files 119 119
Lines 7062 7083 +21
===========================================
+ Hits 4488 4510 +22
Misses 2314 2314
+ Partials 260 259 -1 |
sunnya97
changed the title
sunnya97
force-pushed
the
sunny/gov_tallyresults
branch
from
8f2dcb2
to
d19b2df
Compare
cwgoes
suggested changes
Aug 6, 2018
x/gov/proposals.go
Outdated
| // checks if two proposals are equal | ||
| func TallyResultEqual(resultA TallyResult, resultB TallyResult) bool { | ||
| if resultA.Yes.Equal(resultB.Yes) && | ||
| resultA.Abstain.Equal(resultB.Yes) && |
There was a problem hiding this comment.
resultA.Abstain.Equal(resultB.Abstain)?
x/gov/proposals.go
Outdated
| if resultA.Yes.Equal(resultB.Yes) && | ||
| resultA.Abstain.Equal(resultB.Yes) && | ||
| resultA.No.Equal(resultB.No) && | ||
| resultA.NoWithVeto.Equal(resultB.Yes) { |
There was a problem hiding this comment.
resultA.NoWithVeto.Equal(resultB.NoWithVeto)?
x/gov/endblocker_test.go
Outdated
| @@ -166,6 +167,7 @@ func TestTickPassedVotingPeriod(t *testing.T) { | |||
| require.False(t, depositsIterator.Valid()) | |||
| depositsIterator.Close() | |||
| require.Equal(t, StatusRejected, keeper.GetProposal(ctx, proposalID).GetStatus()) | |||
| require.True(t, TallyResultEqual(keeper.GetProposal(ctx, proposalID).GetTallyResult(), EmptyTallyResult())) | |||
There was a problem hiding this comment.
Can we add a quick testcase for a non-empty tally result?
There was a problem hiding this comment.
Added in following test, TestSlashing
|
Also, can we make sure the |
|
@cwgoes At the moment, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/)PENDING.mdthat include links to the relevant issue or PR that most accurately describes the change.cmd/gaiaandexamples/For Admin Use: