-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag client/v2 v2.0.0-beta.2 #19530
Comments
Which simapp are you talking about? We make sure simapp on release branches depends only on released software. |
Oh yeah, client/v2 should have been tagged at the same time as 0.50.4 (see the changelog date updated there too #19432). Then dependabot would have upgrade it. |
I'll tag it tomorrow after more tests on name resolving from the keyring. |
After more careful checks, the name resolving fixes work well, but I want to look if we can make one more improvement before release. |
Note, when upgrading to client v2.0.0-beta.2, those are the changes you should make in your root.go: https://github.com/cosmosregistry/chain-minimal/pull/143/files |
Summary
Currently simapp depends on
cosmossdk.io/client/v2 v2.0.0-beta.1.0.20240124105859-5ad1805d0e79
. Compared to the latest release, it has some differences in handling sign modes.Since simapp is supposed to be an example, it would be nice it only depended on released versions. Sometimes this can make debugging pretty nebulous.
The text was updated successfully, but these errors were encountered: