Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag client/v2 v2.0.0-beta.2 #19530

Closed
roy-dydx opened this issue Feb 22, 2024 · 7 comments
Closed

Tag client/v2 v2.0.0-beta.2 #19530

roy-dydx opened this issue Feb 22, 2024 · 7 comments
Assignees

Comments

@roy-dydx
Copy link

Summary

Currently simapp depends on cosmossdk.io/client/v2 v2.0.0-beta.1.0.20240124105859-5ad1805d0e79. Compared to the latest release, it has some differences in handling sign modes.

Since simapp is supposed to be an example, it would be nice it only depended on released versions. Sometimes this can make debugging pretty nebulous.

@roy-dydx roy-dydx added the T:Docs Changes and features related to documentation. label Feb 22, 2024
@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Feb 22, 2024
@julienrbrt
Copy link
Member

julienrbrt commented Feb 22, 2024

Which simapp are you talking about? We make sure simapp on release branches depends only on released software.

@roy-dydx
Copy link
Author

@julienrbrt
Copy link
Member

julienrbrt commented Feb 22, 2024

Oh yeah, client/v2 should have been tagged at the same time as 0.50.4 (see the changelog date updated there too #19432). Then dependabot would have upgrade it.
I actually forgot to tag. But rest assured, normally simapp only depends on released software.

@julienrbrt
Copy link
Member

I'll tag it tomorrow after more tests on name resolving from the keyring.

@github-project-automation github-project-automation bot moved this from 👀 To Do to 🥳 Done in Cosmos-SDK Feb 22, 2024
@julienrbrt julienrbrt self-assigned this Feb 23, 2024
@julienrbrt
Copy link
Member

After more careful checks, the name resolving fixes work well, but I want to look if we can make one more improvement before release.

@julienrbrt julienrbrt reopened this Feb 26, 2024
@github-project-automation github-project-automation bot moved this from 🥳 Done to 👀 To Do in Cosmos-SDK Feb 26, 2024
@julienrbrt julienrbrt changed the title [Documentation]: simapp should depend on released versions of cosmos packages Tag client/v2 v2.0.0-beta.2 Feb 26, 2024
@julienrbrt julienrbrt removed the T:Docs Changes and features related to documentation. label Feb 26, 2024
@julienrbrt julienrbrt moved this from 👀 To Do to ✍ In Progress in Cosmos-SDK Feb 26, 2024
@julienrbrt julienrbrt moved this from 🤸‍♂️ In Progress to 📋 Backlog in Cosmos-SDK Jun 4, 2024
@julienrbrt
Copy link
Member

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Jun 19, 2024
@julienrbrt
Copy link
Member

Note, when upgrading to client v2.0.0-beta.2, those are the changes you should make in your root.go: https://github.com/cosmosregistry/chain-minimal/pull/143/files

@tac0turtle tac0turtle removed this from Cosmos-SDK Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants