--encoding option needs to be removed as it is no longer in use

[jackzampolin]

The CLI has a top level --encoding option that is no longer useful since we switched to bech32 this needs to be removed.

[mslipper]

So the encoding flag is defined by the tendermint binary and mixed into the gaiacli command by this method in Tendermint's setup.go:

// PrepareMainCmd is meant for client side libs that want some more flags
//
// This adds --encoding (hex, btc, base64) and --output (text, json) to
// the command.  These only really make sense in interactive commands.
func PrepareMainCmd(cmd *cobra.Command, envPrefix, defaultHome string) Executor {
	cmd.PersistentFlags().StringP(EncodingFlag, "e", "hex", "Binary encoding (hex|b64|btc)")
	cmd.PersistentFlags().StringP(OutputFlag, "o", "text", "Output format (text|json)")
	cmd.PersistentPreRunE = concatCobraCmdFuncs(validateOutput, cmd.PersistentPreRunE)
	return PrepareBaseCmd(cmd, envPrefix, defaultHome)
}

To confirm, I'll basically be moving this functionality into gaiacli. Is this OK?

[jackzampolin]

That is cool. Just tag me on the PR. That flag shouldn't be in gaiacli

[alexanderbez]

Yeah I think it should just be removed from TM?

[jackzampolin]

I think tendermint still uses some of the other key formats, so they might need it... cc @jlandrews

[zramsay]

#1838