Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server/v1 may produce a hash of empty string instead of nil, should server/v2? #20513

Closed
Tracked by #20439
kocubinski opened this issue May 31, 2024 · 2 comments · Fixed by #20775
Closed
Tracked by #20439

server/v1 may produce a hash of empty string instead of nil, should server/v2? #20513

kocubinski opened this issue May 31, 2024 · 2 comments · Fixed by #20775
Assignees
@tac0turtle
Labels
C:server/v2 Issues related to server/v2

Comments

@kocubinski
Copy link
Member

kocubinski commented May 31, 2024 •
edited
Loading

Needs research, see #20412 (comment)
@kocubinski kocubinski mentioned this issue May 31, 2024
Closed
21 tasks
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label May 31, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK May 31, 2024
@kocubinski kocubinski added C:server/v2 Issues related to server/v2 and removed needs-triage Issue that needs to be triaged labels May 31, 2024
@tac0turtle
Copy link
Member

yes this is expected by some users. Since its logic that is expected lets recreate it

@tac0turtle tac0turtle self-assigned this Jun 4, 2024
@tac0turtle
Copy link
Member

i can take this on when simapp v2 is merged

@tac0turtle tac0turtle mentioned this issue Jun 25, 2024
Merged
12 tasks
@tac0turtle tac0turtle moved this from 📋 Backlog to 👀 Waiting / In review in Cosmos-SDK Jul 1, 2024
@github-project-automation github-project-automation bot moved this from 👀 Waiting / In review to 🥳 Done in Cosmos-SDK Jul 2, 2024
@tac0turtle tac0turtle removed this from Cosmos-SDK Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tac0turtle tac0turtle

Labels
C:server/v2 Issues related to server/v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: set empty hash to hash of nothing cosmos/cosmos-sdk
2 participants
@kocubinski @tac0turtle