Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revoked validators in genesis cause a panic #2088

Closed
4 tasks
zmanian opened this issue Aug 20, 2018 · 1 comment
Closed
4 tasks

Revoked validators in genesis cause a panic #2088

zmanian opened this issue Aug 20, 2018 · 1 comment

Comments

@zmanian
Copy link
Member

zmanian commented Aug 20, 2018

My impression was that #1853 was expected to fix this bug but it occurs on v0.24

Reproduce with the gaia-7005 state dump here : https://gist.github.com/zmanian/3479be2bc53b1fc571ddc5da1c4627fa

➜  cosmos-sdk git:(d5652d96) ✗ gaiad start                           
I[08-20|00:11:23.882] Starting ABCI with Tendermint                module=main 
I[08-20|00:11:23.911] Starting multiAppConn                        module=proxy impl=multiAppConn
I[08-20|00:11:23.911] Starting localClient                         module=abci-client connection=query impl=localClient
I[08-20|00:11:23.911] Starting localClient                         module=abci-client connection=mempool impl=localClient
I[08-20|00:11:23.911] Starting localClient                         module=abci-client connection=consensus impl=localClient
I[08-20|00:11:23.911] ABCI Handshake                               module=consensus appHeight=0 appHash=
I[08-20|00:11:23.911] ABCI Replay Blocks                           module=consensus appHeight=0 storeHeight=0 stateHeight=0
panic: revoked validator cannot be bonded, address: [74 198 132 115 127 101 179 0 76 133 120 122 56 163 5 248 124 242 2 235]


goroutine 1 [running]:
github.com/cosmos/cosmos-sdk/x/stake/keeper.Keeper.UpdateBondedValidatorsFull(0x4ca9980, 0xc4200bf030, 0xc4207960e0, 0x4ca9980, 0xc4200bf010, 0x4c30b78, 0xc4207960e0, 0x4, 0x4cb1780, 0xc4207e9590, ...)
	/Users/zakimanian/go/src/github.com/cosmos/cosmos-sdk/x/stake/keeper/validator.go:534 +0xa3c
github.com/cosmos/cosmos-sdk/x/stake.InitGenesis(0x4cb1780, 0xc4207e9590, 0xc42094e700, 0x8, 0x4ca9980, 0xc4200bf030, 0xc4207960e0, 0x4ca9980, 0xc4200bf010, 0x4c30b78, ...)
	/Users/zakimanian/go/src/github.com/cosmos/cosmos-sdk/x/stake/genesis.go:47 +0x813
github.com/cosmos/cosmos-sdk/cmd/gaia/app.(*GaiaApp).initChainer(0xc420a80200, 0x4cb1780, 0xc4207e9590, 0xc42094e700, 0x8, 0x75bcd15, 0xed2f9f700, 0x0, 0xc420a1ec60, 0x9, ...)
	/Users/zakimanian/go/src/github.com/cosmos/cosmos-sdk/cmd/gaia/app/app.go:179 +0x36b
github.com/cosmos/cosmos-sdk/cmd/gaia/app.(*GaiaApp).(github.com/cosmos/cosmos-sdk/cmd/gaia/app.initChainer)-fm(0x4cb1780, 0xc4207e9590, 0xc42094e700, 0x8, 0x75bcd15, 0xed2f9f700, 0x0, 0xc420a1ec60, 0x9, 0xc42094e640, ...)
	/Users/zakimanian/go/src/github.com/cosmos/cosmos-sdk/cmd/gaia/app/app.go:109 +0xb6
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).InitChain(0xc420a9a000, 0x75bcd15, 0xed2f9f700, 0x0, 0xc420a1ec60, 0x9, 0xc42094e640, 0xc420950000, 0x6a, 0x6a, ...)
	/Users/zakimanian/go/src/github.com/cosmos/cosmos-sdk/baseapp/baseapp.go:246 +0x1a7
github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/abci/client.(*localClient).InitChainSync(0xc4200a0c00, 0x75bcd15, 0xed2f9f700, 0x0, 0xc420a1ec60, 0x9, 0xc42094e640, 0xc420950000, 0x6a, 0x6a, ...)
	/Users/zakimanian/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/abci/client/local_client.go:199 +0x9e
github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/proxy.(*appConnConsensus).InitChainSync(0xc4200f18a0, 0x75bcd15, 0xed2f9f700, 0x0, 0xc420a1ec60, 0x9, 0xc42094e640, 0xc420950000, 0x6a, 0x6a, ...)
	/Users/zakimanian/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/proxy/app_conn.go:65 +0x6b
github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/consensus.(*Handshaker).ReplayBlocks(0xc420a98dc0, 0xc420a19e10, 0x9, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/Users/zakimanian/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/consensus/replay.go:278 +0x102e
github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/consensus.(*Handshaker).Handshake(0xc420a98dc0, 0x4cbbea0, 0xc420794700, 0x4, 0x4cb2340)
	/Users/zakimanian/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/consensus/replay.go:246 +0x426
github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/proxy.(*multiAppConn).OnStart(0xc420794700, 0xc4204cff00, 0x15)
	/Users/zakimanian/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/proxy/multi_app_conn.go:108 +0x527
github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/libs/common.(*BaseService).Start(0xc420794700, 0x0, 0x0)
	/Users/zakimanian/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/libs/common/service.go:130 +0x3bd
github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/node.NewNode(0xc420a9cd80, 0x4cb3d00, 0xc420aa19a0, 0x4ca6640, 0xc420a5b380, 0xc4200bf510, 0x4c305b0, 0xc4200bf530, 0x4cb2340, 0xc420a5b3c0, ...)
	/Users/zakimanian/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/node/node.go:187 +0x693
github.com/cosmos/cosmos-sdk/server.startInProcess(0xc4204c5200, 0xc4204c5240, 0x1d, 0x0, 0x0)
	/Users/zakimanian/go/src/github.com/cosmos/cosmos-sdk/server/start.go:98 +0x320
github.com/cosmos/cosmos-sdk/server.StartCmd.func1(0xc420aa38c0, 0x525bb00, 0x0, 0x0, 0x0, 0x0)
	/Users/zakimanian/go/src/github.com/cosmos/cosmos-sdk/server/start.go:38 +0xaa
github.com/cosmos/cosmos-sdk/vendor/github.com/spf13/cobra.(*Command).execute(0xc420aa38c0, 0x525bb00, 0x0, 0x0, 0xc420aa38c0, 0x525bb00)
	/Users/zakimanian/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/spf13/cobra/command.go:698 +0x46d
github.com/cosmos/cosmos-sdk/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc420aa2900, 0x49c6040, 0xc420857e01, 0xc4204c5400)
	/Users/zakimanian/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/spf13/cobra/command.go:783 +0x2e4
github.com/cosmos/cosmos-sdk/vendor/github.com/spf13/cobra.(*Command).Execute(0xc420aa2900, 0xc4204c5400, 0xc420857ed8)
	/Users/zakimanian/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/spf13/cobra/command.go:736 +0x2b
github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/libs/cli.Executor.Execute(0xc420aa2900, 0x4c31168, 0x2, 0xc420a1ace0)
	/Users/zakimanian/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/libs/cli/setup.go:89 +0x4e
main.main()
	/Users/zakimanian/go/src/github.com/cosmos/cosmos-sdk/cmd/gaia/cmd/gaiad/main.go:38 +0x214

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants