Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache the decoded structs instead of the encoded bytes #2194

Closed
cwgoes opened this issue Aug 30, 2018 · 3 comments
Closed

Cache the decoded structs instead of the encoded bytes #2194

cwgoes opened this issue Aug 30, 2018 · 3 comments
Labels
S:proposed T: Performance Performance improvements

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Aug 30, 2018

Ref #2187 (comment)

At the moment, I expect there's a lot of redundant encoding/decoding through the cache layer - we update a validator struct, Amino-encode the updated struct, save it to the cache, promptly read it back from the cache and Amino-decode it again! Looking at the first version of benchmarks, it looks like Amino is a substantial bottleneck; I think if we can find an elegant way to do this it might be quite helpful.

Probably not prelaunch unless it's really easy.

cc @ValarDragon thoughts?

@ValarDragon
Copy link
Contributor

ValarDragon commented Aug 31, 2018

Lol we had the same exact though here. I'm in favor of keeping the conversation on the other issue due to having already started the conversation there, and there being a proposal to evaluate.

I think if there is anything we want to optimize, benchmarks indicate that this is the first thing we should be doing for speed.

@alexanderbez
Copy link
Contributor

++ seems like we can close this one?

@cwgoes
Copy link
Contributor Author

cwgoes commented Aug 31, 2018

Closed in favor of #2193.

@cwgoes cwgoes closed this as completed Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S:proposed T: Performance Performance improvements
Projects
None yet
Development

No branches or pull requests

4 participants