Remove ripemd160 entirely #2308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
We already made this decision awhile ago, and have had tendermint switched for awhile. I was surprised to find ripemd still used within the storeinfo. This actually leads me to think the new "byter" API change in the tendermint PR RFC compliance is better, as it avoids things like this from ever happening.
ValarDragon
force-pushed
the
dev/remove_ripemd160
branch
from
3f82a67 to
76eb84e
Compare
ValarDragon
added
ready-for-review
T: API Breaking
Codecov Report
@@ Coverage Diff @@
## develop #2308 +/- ##
========================================
Coverage 63.94% 63.94%
========================================
Files 140 140
Lines 8689 8689
========================================
Hits 5556 5556
Misses 2757 2757
Partials 376 376 |
cwgoes
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already made this decision awhile ago, and have had tendermint switched
for awhile. I was surprised to find ripemd still used within the storeinfo.
This actually leads me to think the new "byter" API change in the tendermint
PR, for RFC compliance is better, as it avoids things like this from ever happening.
Targeted PR against correct branch (see CONTRIBUTING.md)
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: