Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider whether or not we want to trust the full node by default for post commands #2322

Closed
cwgoes opened this issue Sep 13, 2018 · 10 comments

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Sep 13, 2018

e.g. sending a transaction

I think perhaps not - otherwise a full node could lie about sequence number, account number, etc.

cc @HaoyangLiu

ref https://github.com/cosmos/cosmos-sdk/pull/2210/files#diff-38b4a4a9824366646939d96f3dc02184L65

@ValarDragon
Copy link
Contributor

I thought the plan was to do merkle proofs for account querying? You would then have sequence number, account number, etc.

@rigelrozanski
Copy link
Contributor

Well - the sender needs to sign the message anyways - so if the signed message doesn't make the sequence number amounts etc. the message would just fail (would fees be deducted however? - I don't think so because we check the signatures before deducting the fees)

meh, so I don't see how this is really an issue, the worst a node could do would be not broadcast your transaction

@ValarDragon
Copy link
Contributor

ValarDragon commented Sep 13, 2018

Fees won't be deducted if the sequence number is invalid, so I agree, this does seem like a non-issue as long as your connected to multiple full nodes.

@jackzampolin
Copy link
Member

Closing this as the lite client proof system is undergoing a refactor.

@cwgoes
Copy link
Contributor Author

cwgoes commented May 28, 2019

Closing this as the lite client proof system is undergoing a refactor.

We should explicitly consider this griefing vector though.

@cwgoes cwgoes reopened this May 28, 2019
@alexanderbez
Copy link
Contributor

What is the griefing vector? Spam?

@cwgoes
Copy link
Contributor Author

cwgoes commented May 28, 2019

What is the griefing vector? Spam?

Getting the client to sign an invalid transaction by returning the wrong current account nonce or account number.

@jackzampolin
Copy link
Member

Yes, but I don't think this issue is the right spot to track that. Going to close.

@rigelrozanski
Copy link
Contributor

Where's the best place to track that?

@jackzampolin
Copy link
Member

Currently writes default to trust the node and queries default to not trust. Going to go ahead and close this issue. If reopening, please add an actionable item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants