Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognizing finish of catching up #2387

Closed
4 tasks
Thunnini opened this issue Sep 24, 2018 · 5 comments
Closed
4 tasks

Recognizing finish of catching up #2387

Thunnini opened this issue Sep 24, 2018 · 5 comments
Labels

Comments

@Thunnini
Copy link
Contributor

Thunnini commented Sep 24, 2018

Summary

I want to add metrics on cosmos-sdk. But without recognizing fast sync, metrics will be strange until finishing catching up.

Problem Definition

I want to add metrics on cosmos-sdk. But without recognizing fast sync, metrics will be strange until finishing catching up.

Proposal

When the fast sync is complete, tendermint informs completion via SetOption abci.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

What exact metrics do you want to add @Thunnini? Also, take a look at #2169.

@rigelrozanski
Copy link
Contributor

I think that @Thunnini is looking for a message to be sent to the application for customized metrics? - it sounds like this issue should be in https://github.com/tendermint/tendermint/issues though

@Thunnini
Copy link
Contributor Author

Thunnini commented Sep 25, 2018

As mentioned above, I want to create metrics for basic modules and my custom modules on cosmos-sdk. But until finishing catching up, I may have very strange metrics because I do not know whether it is fast sync now or not. I want skip tracking up metrics during fast sync... On second thought, however, I think it is related to Tendermint. I'm sorry.

@rigelrozanski
Copy link
Contributor

yeah no sorries required! If you'd like to reopen this issue in tendermint that would be much appreciated :)

@jackzampolin
Copy link
Member

jackzampolin commented Oct 8, 2018

I think there is currently a syncing={true|false} metric that should be monitored to see if the node is synching. This should give operators an idea of if the metrics can be trusted or not. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants