Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Block conflicting redelegations #2500

Merged
merged 4 commits into from
Oct 16, 2018

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Oct 15, 2018

Quick fix to #1402 for GoS, but we should eventually add an index instead.

Simply prevents redelegation by delegator D from validator A to validator B if any existing redelegation by D from A to B already exists. Includes a testcase.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Oct 15, 2018

Codecov Report

Merging #2500 into develop will decrease coverage by <.01%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           develop    #2500      +/-   ##
===========================================
- Coverage    61.38%   61.37%   -0.01%     
===========================================
  Files          153      153              
  Lines         9612     9615       +3     
===========================================
+ Hits          5900     5901       +1     
- Misses        3301     3302       +1     
- Partials       411      412       +1

@cwgoes cwgoes changed the title WIP: Block conflicting redelegations R4R: Block conflicting redelegations Oct 15, 2018
Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it - thanks for the patch

@rigelrozanski rigelrozanski merged commit c0ce451 into develop Oct 16, 2018
@rigelrozanski rigelrozanski deleted the cwgoes/quick-redelegation-unbonding-index-fix branch October 16, 2018 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants