-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/block endpoint could be cleaner #2504
Comments
+1 |
Agree. I think this issue should go on https://github.com/tendermint/tendermint instead |
Maybe, but imo the SDK API doesn't need to reflect the Tendermint API. |
Moved to tendermint/tendermint#2689 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
I am playing around with the block endpoint that's available on port 26657, and I noticed some redundant header information. Im posting this as a feature request as I'm not sure if its really a bug.
Problem Definition
When you request for example the api endpoint :26657/block?height=10000, you see a section with block_meta and block. However, they both contain a header part that contain exactly the same information and is therefor being redundant.
Proposal
Remove the header part from block_meta or remove the header part from block. Perhaps choosing the first option is best as the header part is actually containing meta information about the block.
If there is a good reason why we need two headers with the same information, I'd like to know.
Thanks.
The text was updated successfully, but these errors were encountered: