Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: Tags.AppendTag do not work #2625

Closed
wants to merge 4 commits into from
Closed

Conversation

elvin-du
Copy link
Contributor

@elvin-du elvin-du commented Oct 29, 2018

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Oct 29, 2018

Codecov Report

Merging #2625 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2625      +/-   ##
===========================================
- Coverage    58.84%   58.83%   -0.02%     
===========================================
  Files          152      152              
  Lines         9424     9420       -4     
===========================================
- Hits          5546     5542       -4     
  Misses        3508     3508              
  Partials       370      370

@ValarDragon
Copy link
Contributor

Could you write a test case showing that this used to fail? I'm confused as to why this changes anything.

@elvin-du
Copy link
Contributor Author

sorry, my mistake, I open another pr to fix the bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants