Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodes in a local testnet should have a canonical genesis time #2691

Closed
4 tasks done
alexanderbez opened this issue Nov 5, 2018 · 1 comment · Fixed by #2692
Closed
4 tasks done

Nodes in a local testnet should have a canonical genesis time #2691

alexanderbez opened this issue Nov 5, 2018 · 1 comment · Fixed by #2692
Assignees
@alexanderbez
Labels
T: Tests

Comments

@alexanderbez
Copy link
Contributor

alexanderbez commented Nov 5, 2018 •
edited
Loading

Summary

TM v0.26 requires the time on block 1 to equal the genesis time. However, when we spin up n nodes in a local testnet they have a very tiny delta in their genesis time (because they're created sequentially and independently). This causes the network to run indefinitely in rounds for height 1.

This will fix the tesnet CI pipeline.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez alexanderbez self-assigned this Nov 5, 2018
@alexanderbez alexanderbez mentioned this issue Nov 5, 2018
Merged
5 tasks
@rigelrozanski
Copy link
Contributor

whoa! good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderbez alexanderbez

Labels
T: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[R4R] Update testnet to use canonical genesis time cosmos/cosmos-sdk
2 participants
@alexanderbez @rigelrozanski