Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that store impls do not allow nil values #2707

Closed
jaekwon opened this issue Nov 7, 2018 · 0 comments
Closed

Test that store impls do not allow nil values #2707

jaekwon opened this issue Nov 7, 2018 · 0 comments

Comments

@jaekwon
Copy link
Contributor

jaekwon commented Nov 7, 2018

KVStore, CacheKVStore, etc should not allow nil values to be stored.
It's sometimes used accidentally to delete a value, but .Delete() should be used instead.

The issue is that we should write tests for all of our store impls to enforce this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants