Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ValidateBasic to Tx interface (or just StdTx) #2779

Closed
cwgoes opened this issue Nov 12, 2018 · 1 comment · Fixed by #2863
Closed

Add ValidateBasic to Tx interface (or just StdTx) #2779

cwgoes opened this issue Nov 12, 2018 · 1 comment · Fixed by #2863
Assignees

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Nov 12, 2018

Proposed by @ebuchman - this can check positive gas, positive fee, not-too-many multisigs, etc. in a self-contained stateless abstraction.

@ebuchman
Copy link
Member

It should be on the Tx interface, not just StdTx.

Basically any input coming from a user ever should have ValidateBasic method to sanity check the values in a stateless manner.

We already have it on Msg, but Txs can contain data beyond the Msgs, so tx.ValidateBasic should check those as well.

Unclear whether tx.ValidateBasic should run msg.ValidateBasic for all msgs - probably not, let the baseapp handle that for everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants