OnValidatorModified misused for some delegation situations

[rigelrozanski]

Ref #2764 (comment)

this isn't a critical bug, it's more just overkill.

OnValidatorModified withdraws all the fees of the validator including commission to the validators liquid account. This makes sense to occur for:

• validator commission rate changes
• validator changes self-bond

This procedure contains all the necessary updates but also more for:

• validator power change due to (non-self) delegation

really we should create a new type of function hook which is used for non-self delegations. This hook does not need to force the validator to withdraw their rewards to their liquid account, but does require them to withdraw global pool accum.

---

going to think about this more - maybe not even a bad idea to just leave this anyways.
CC @cwgoes

[jackzampolin]

Is this still an issue?

[cwgoes]

No, was fixed by F1.