Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Governance API has miss-spelled English word in JSON response #2798

Closed
1 of 4 tasks
jmdfm opened this issue Nov 13, 2018 · 3 comments
Closed
1 of 4 tasks

Governance API has miss-spelled English word in JSON response #2798

jmdfm opened this issue Nov 13, 2018 · 3 comments
Labels
good first issue Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@jmdfm
Copy link
Contributor

jmdfm commented Nov 13, 2018

Summary of Bug

Calls to the Governance API to retrieve deposits on a proposal have a miss-spelling depositer in the JSON payload. The correct English word should be depositor.

Steps to Reproduce

  1. Create a proposal.
  2. Query the deposits on that proposal:
  3. See the word depositer returned in the JSON payload:
cosmos-sdk master % curl -k https://0.0.0.0:1317/gov/proposals/2/deposits
[
  {
    "depositer": "cosmos1ys9dj97sm9pgzg3e6sgsxfwlfau22q6w2addad",
    "proposal_id": "2",
    "amount": [
      {
        "denom": "steak",
        "amount": "10"
      }
    ]
  }
]

Would be happy to submit a PR if open to it


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez alexanderbez added good first issue Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Nov 14, 2018
@ValarDragon
Copy link
Contributor

Please do submit a PR!

@jmdfm
Copy link
Contributor Author

jmdfm commented Nov 14, 2018

@ValarDragon Submitted a PR!

@jmdfm
Copy link
Contributor Author

jmdfm commented Nov 22, 2018

Closing this as the PR was accepted and merged

@jmdfm jmdfm closed this as completed Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

No branches or pull requests

3 participants