Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change inflation to not have more go to the proposer #3023

Closed
ValarDragon opened this issue Dec 6, 2018 · 12 comments
Closed

Change inflation to not have more go to the proposer #3023

ValarDragon opened this issue Dec 6, 2018 · 12 comments
Labels
C:x/distribution distribution module related S:proposed
Milestone

Comments

@ValarDragon
Copy link
Contributor

ValarDragon commented Dec 6, 2018

Inflation going through the normal fee process where it gets divied based on number of validators who signed the block, with a slight advantage to the proposer is sub-ideal. This is necessary for fees, but not for inflation.

Instead I think inflation should be divied evenly to all of the staked tokens. This will remove the incentive for proposers to publish blocks with no tx fees, but that is a good thing. If there are no tx fees, then that means there only txs that are from the proposer. Thus it is fine not incentivize this blocks creation, as that would just create larger state bloat / increase sync times.

_Originally posted by @ValarDragon and @cwgoes in #2990 (comment)

@ValarDragon ValarDragon added S:proposed C:x/distribution distribution module related labels Dec 6, 2018
@rigelrozanski
Copy link
Contributor

I think this is in the intended behaviour as per slack discussion. Obviously should be addressed with F1 implementation

@sunnya97
Copy link
Member

sunnya97 commented Dec 7, 2018

@rigelrozanski I'm pretty sure the agreed upon PoS Economic Design was that block rewards get distributed evenly, and tx fees have a slight proposer extra reward?

@rigelrozanski
Copy link
Contributor

Correct, ultimately, distribution ought to have regard for separation of block rewards (no proposer reward) and fees (with proposer reward) - it just makes the code more messy so currently everything simply goes through the fee distribution mechanism (which was also agreed upon in other discussions in Berkley).

We could do this prelaunch if we so desire, I don't think it's going to make a huge difference though and may just be wasted effort as we should really be doing this at the same time as F1 updates.

@cwgoes cwgoes mentioned this issue Dec 14, 2018
5 tasks
@jackzampolin
Copy link
Member

This will require a governance proposal but will be a relatively small change otherwise.

@jackzampolin jackzampolin added this to the v0.38.0 milestone Sep 17, 2019
@zmanian
Copy link
Member

zmanian commented Sep 17, 2019

We should have bonuses for including signatures on the commits but no proposer bonus. Social liveness incentives appear to be enough

@cwgoes
Copy link
Contributor

cwgoes commented Sep 17, 2019

Hmm, I would really like to see a more comprehensive analysis here a la #3529.

(though others may come to different conclusions than I did!)

@gavinly
Copy link
Contributor

gavinly commented Sep 18, 2019

I'd like to see math evidence of the proposer bonus accelerating the centralization of stake.

@cwgoes
Copy link
Contributor

cwgoes commented Sep 18, 2019

I'd like to see math evidence of the proposer bonus accelerating the centralization of stake.

It doesn't, at least not in the first-order distribution, since all rewards are stake-proportional (linearly) and proposer election is as well. @ValarDragon's point is that we probably don't want to pay a proposer reward for proposing blocks which have zero transaction fees (and thus just cost full nodes / validators storage & compute).

@tnachen tnachen modified the milestones: v0.38.0, Backlog Oct 1, 2019
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@cwgoes
Copy link
Contributor

cwgoes commented Jul 17, 2020

This is still applicable, albeit low-priority.

@ValarDragon
Copy link
Contributor Author

ValarDragon commented Jan 30, 2022

I now agree with Zaki, all we really should be incentivizing is precommit inclusion. I think proposer bonus for everything else is unneeded.

In the abstract, I think its right for fees to have proposer bonuses (and nothing else).

Concretely though, I've now generally changed my mind, that we should be aiming for tx fees to in totality be negligibile worth, and constantly be pushing our scalability to enable this. This counteracts with there ever being sufficient incentive for inspiring validator action in improving mempools (or dis-incentive to not run a mempool at all).

(Granted, I potentially have a hot take here, since unlike ~every other big blockchain ecosystem, I want Cosmos to eliminate MEV, rather than democratize its extraction for better tx-fee-reward-equivalents)

@tac0turtle
Copy link
Member

closing in favour of #13139

Repository owner moved this from Icebox to Done in Cosmos SDK Maintenance Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/distribution distribution module related S:proposed
Projects
No open projects
Development

No branches or pull requests

10 participants