New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Amino caching #3088

Closed

cwgoes opened this issue Dec 12, 2018 · 1 comment

Labels

Type: Code Hygiene

Contributor

cwgoes commented Dec 12, 2018

Ref #3075 (comment) (copied):

I'm not a fan of this style of caching (not the fault of this PR, more the existing solution), I think it will get messy quickly. Moving the cache into the keeper makes it parallel-keeper-safe but otherwise doesn't help.

I'd rather we find a way to do this generally with Amino (maybe through the codec object).

cc @jackzampolin @jaekwon

cwgoes added core Type: Code Hygiene labels

cwgoes mentioned this issue

R4R: Move validator cache to the keeper in stake #3075

Merged

Contributor Author

cwgoes commented Dec 14, 2018

Closing in favor of #2193, which is basically the same thing.

cwgoes closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment