-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REST tx endpoint result status code should reflect success #311
Comments
relevant for #324 |
yep! i agree here. i’d rather see empty 200’s than 400 when a user doesn’t have a balance, for example. but should be consistent no matter what we choose. |
I think this is no longer relevant, please re-open if otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the rest of the endpoints a not successful request produces a 4** status code. The tx endpoint returns a 200 but delivers some code in check_tx. I think this should be consistent through all the endpoints.
To reproduce try to bond with delegator with pubkey '88564A32500A120AA72CEFBCF5462E078E5DDB70B6431F59F778A8DC4DA719A4' on gaia-2-dev.
The text was updated successfully, but these errors were encountered: