Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/gov tally result in GET /gov/proposal/{id} wrong #3155

Closed
jackzampolin opened this issue Dec 18, 2018 · 3 comments
Closed

x/gov tally result in GET /gov/proposal/{id} wrong #3155

jackzampolin opened this issue Dec 18, 2018 · 3 comments
Labels

Comments

@jackzampolin
Copy link
Member

The LCD endpoint(s) for querying governance proposal(s) includes a .value.tally_result field with the following data:

"tally_result": {
        "yes": "0.0000000000",
        "abstain": "0.0000000000",
        "no": "0.0000000000",
        "no_with_veto": "0.0000000000"
      },

Even if the proposal has votes on it, this data is always 0s. We should fix the endpoint to return the same data as /gov/proposals/{id}/tally which for the same proposal returns:

{
  "yes": "721579.3999994578",
  "abstain": "0.0000000000",
  "no": "96512.0000000000",
  "no_with_veto": "26111.0000000000"
}
@fedekunze
Copy link
Collaborator

See discussion from #2859

@fedekunze
Copy link
Collaborator

should we close and move this to #2859 ?

@jackzampolin
Copy link
Member Author

I think that would make sense @fedekunze

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants