-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a simple maximum length for validator descriptions #3420
Comments
We were discussing proposal description length limits. But I think the same rules apply. |
Need to add a check in the validate basic functions of |
We discussed that the max possible >5000 chars would be good. Proposals probably need to be complex and we don't want them to be posted on other platforms and linked if possible. |
Is this issue with regards to Validator description lengths or Governance proposal description lengths? Validator Details length is already capped at 280. For some reason, validator identity length is capped at 3000, though. Is there a reason why that is so high? |
I meant |
Oh ok. Yeah, I'll go ahead and cap it at 5000 for now. Should I decrease the max validator Identity length btw? |
no oppinion
can we test what the max is and go with something close? |
What do you mean test what the max is? |
Max in sense of: What is the max proposal length so that the tx is stil accepted by Tendermints max TX size limit. |
I think we should choose a much smaller maximum proposal length, as the Tendermint max TX size could change later for other reasons. |
We could change the proposal length when the Tendermint max TX size changes. |
Ref luniehq/lunie#1871 (comment)
1000 characters, perhaps? Ideally validators could include structured JSON which frontends could parse.
The text was updated successfully, but these errors were encountered: