Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple maximum length for validator descriptions #3420

Closed
cwgoes opened this issue Jan 28, 2019 · 11 comments · Fixed by #3434
Closed

Add a simple maximum length for validator descriptions #3420

cwgoes opened this issue Jan 28, 2019 · 11 comments · Fixed by #3434
Assignees

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Jan 28, 2019

Ref luniehq/lunie#1871 (comment)

1000 characters, perhaps? Ideally validators could include structured JSON which frontends could parse.

@faboweb
Copy link
Contributor

faboweb commented Jan 29, 2019

We were discussing proposal description length limits. But I think the same rules apply.
1000 characters sounds like a good first mark.

@jackzampolin
Copy link
Member

Need to add a check in the validate basic functions of create-validator and edit-validator (i.e. all messages that can change or set a description)

@faboweb
Copy link
Contributor

faboweb commented Jan 29, 2019

We discussed that the max possible >5000 chars would be good. Proposals probably need to be complex and we don't want them to be posted on other platforms and linked if possible.

@sunnya97
Copy link
Member

Is this issue with regards to Validator description lengths or Governance proposal description lengths?

Validator Details length is already capped at 280. For some reason, validator identity length is capped at 3000, though. Is there a reason why that is so high?

@faboweb
Copy link
Contributor

faboweb commented Jan 29, 2019

I meant Governance proposal. Validator descriptions could probably be a lot shorter.

@sunnya97
Copy link
Member

Oh ok. Yeah, I'll go ahead and cap it at 5000 for now.

Should I decrease the max validator Identity length btw?

@faboweb
Copy link
Contributor

faboweb commented Jan 29, 2019

Should I decrease the max validator Identity length btw?

no oppinion

Oh ok. Yeah, I'll go ahead and cap it at 5000 for now.

can we test what the max is and go with something close?

@sunnya97
Copy link
Member

What do you mean test what the max is?

@faboweb
Copy link
Contributor

faboweb commented Jan 29, 2019

Max in sense of: What is the max proposal length so that the tx is stil accepted by Tendermints max TX size limit.

@cwgoes
Copy link
Contributor Author

cwgoes commented Jan 29, 2019

I think we should choose a much smaller maximum proposal length, as the Tendermint max TX size could change later for other reasons.

@faboweb
Copy link
Contributor

faboweb commented Jan 30, 2019

We could change the proposal length when the Tendermint max TX size changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants