Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Simulate from a genesis file #3428

Merged
merged 7 commits into from
Jan 29, 2019
Merged

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Jan 29, 2019

Closes #3182

Includes new Makefile commands test_sim_gaia_custom_genesis_fast and test_sim_gaia_custom_genesis_multi_seed, which both default to using ~/.gaiad/config/genesis.json.

To test with the gaia-10k genesis, download this file to ~/.gaiad/config/genesis.json and run one of those new commands.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes cwgoes added wip tooling dev tooling within the sdk labels Jan 29, 2019
@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #3428 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3428      +/-   ##
===========================================
- Coverage    59.36%   59.34%   -0.03%     
===========================================
  Files          134      134              
  Lines         9972     9972              
===========================================
- Hits          5920     5918       -2     
- Misses        3679     3681       +2     
  Partials       373      373

@cwgoes cwgoes changed the title WIP: Simulate from genesis R4R: Simulate from genesis Jan 29, 2019
@cwgoes cwgoes requested a review from zmanian January 29, 2019 19:29
@cwgoes cwgoes changed the title R4R: Simulate from genesis R4R: Simulate from a genesis file Jan 29, 2019
Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - few comments to address within

Makefile Show resolved Hide resolved
cmd/gaia/app/sim_test.go Outdated Show resolved Hide resolved
cmd/gaia/app/sim_test.go Outdated Show resolved Hide resolved
cmd/gaia/app/sim_test.go Show resolved Hide resolved
x/mock/simulation/simulate.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling dev tooling within the sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants