/validatorsets/{height} endpoint returns incorrect address

[joe-bowman]

Summary of Bug

The /validatorsets/{height} endpoint incorrectly returns a sdk.ValAddress in the address field. The address value that is bech32ified is not the operator address, but the consensus address. In this form, the value is meaningless; it should presumably be displayed in the hex form consistent with other endpoints.

Location of defect:

cosmos-sdk/client/rpc/validators.go

Line 60 in c04c696

Address: sdk.ValAddress(validator.Address),

Steps to Reproduce

make a call to the LCDs /validatorsets/{height} endpoint. The returned address field takes the form of a cosmosvaloper address does not match the known operator address for the given consensus address.

where cosmosvalconspub1zcjduepqz7c4m3te2n0rwfz4z30q6m2dvewn04mkv6u3mxdetrfjpflxew7qrltqdg is chorusone's consensus address:

root@sentry07:/gaiad# curl -s https://lcd:1317/validatorsets/latest | jq . | grep cosmosvalconspub1zcjduepqz7c4m3te2n0rwfz4z30q6m2dvewn04mkv6u3mxdetrfjpflxew7qrltqdg -b2
10476-    {
10482-      "address": "cosmosvaloper10why2pfdjk2vpqu5nvypu97f0p8ev0cjczsmsa",
10555:      "pub_key": "cosmosvalconspub1zcjduepqz7c4m3te2n0rwfz4z30q6m2dvewn04mkv6u3mxdetrfjpflxew7qrltqdg",
10659-      "proposer_priority": "-58328903",
10699-      "voting_power": "1650987"

the returned value cosmosvaloper10why2pfdjk2vpqu5nvypu97f0p8ev0cjczsmsa is not chorusone's operator address, but a bech32ified validator address with the cosmosvaloper HRP.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned