Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken WithdrawValidatorCommission #3837

Closed
4 tasks done
alexanderbez opened this issue Mar 8, 2019 · 0 comments · Fixed by #3836
Closed
4 tasks done

Broken WithdrawValidatorCommission #3837

alexanderbez opened this issue Mar 8, 2019 · 0 comments · Fixed by #3836
Assignees
@alexanderbez
Labels
C:x/distribution distribution module related C:x/staking T:Bug
Milestone
v0.34.0

Comments

@alexanderbez
Copy link
Contributor

alexanderbez commented Mar 8, 2019 •
edited
Loading

Summary of Bug

There are possible cases where WithdrawValidatorCommission can set the validator's remaining commission to zero coins (e.g. 0photino). This is invalid as the SDK considers such coins invalid. Subsequent calls to withdraw commission will cause an error for the x/bank module.

ref: #3836

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderbez alexanderbez

Labels
C:x/distribution distribution module related C:x/staking T:Bug
Projects
None yet
Milestone
v0.34.0
Development

Successfully merging a pull request may close this issue.

Fix WithdrawValidatorCommission cosmos/cosmos-sdk
1 participant
@alexanderbez