R4R Run missing invariants during simulations #4080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4080 +/- ##
===========================================
- Coverage 59.98% 59.95% -0.04%
===========================================
Files 212 211 -1
Lines 15123 15111 -12
===========================================
- Hits 9072 9060 -12
Misses 5431 5431
Partials 620 620 |
rigelrozanski
changed the title
alessio
reviewed
Apr 10, 2019
| @@ -39,3 +39,12 @@ func (k *Keeper) RegisterRoute(moduleName, route string, invar sdk.Invariant) { | |||
| func (k Keeper) Routes() []InvarRoute { | |||
| return k.routes | |||
| } | |||
|
|
|||
| // return all the invariants | |||
| func (k Keeper) Invariants() []sdk.Invariant { | |||
There was a problem hiding this comment.
Can we have a unit test for just this function?
There was a problem hiding this comment.
I gracefully decline, I really can't see how this is useful whatsoever, I'll add a // DONTCOVER though
alessio
reviewed
Apr 10, 2019
alexanderbez
approved these changes
Apr 10, 2019
| simulation.PeriodicInvariant(staking.AllInvariants(app.stakingKeeper, app.feeCollectionKeeper, | ||
| app.distrKeeper, app.accountKeeper), period, 0), | ||
| } | ||
| return simulation.PeriodicInvariants(app.crisisKeeper.Invariants(), period, 0) |
alessio
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just noticed there were a bunch of missing simulatulations in some moreless hidden code ;)
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: