[ICS20] Balance endpoint returns null for empty balance account

[vikmeup]

Summary of Bug

Current endpoint: https://stargate.cosmos.network/bank/balances/cosmos1nk2aalgqtr2tjraqzygtwq5t4dan2rtwvs5fhg
returns null response if the current address does not have any atoms on the account

Expect JSON result:

[
   {
      "denom": "uatom",
      "amount": "0"
   }
]

or

[]

Version

Latest running node on https://stargate.cosmos.network

Steps to Reproduce

curl https://stargate.cosmos.network/bank/balances/cosmos1nk2aalgqtr2tjraqzygtwq5t4dan2rtwvs5fhg

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[vikmeup]

@alexanderbez FYI, same issue for this endpoint: auth/accounts/cosmos1nk2aalgqtr2tjraqzygtwq5t4dan2rtwvs5fhg , coins returned as null

[alexanderbez]

For accounts that do not exist, this has already been fixed! #4065 (I'll include this in the next point release)

With regards to coins, we're going to be implementing #4076 soon which will be a breaking API change.

For now may I suggest checking for null manually?

[kolya182]

@alexanderbez Found another one, https://stargate.cosmos.network/auth/accounts/cosmos1dnhwaj8x8hqn3y8k5yp57e7nljd5l34q3erlpt returns 204 No Content

[kolya182]

For now may I suggest checking for null manually?
Yes, we do it now.

[alexanderbez]

@kolya182 yeah, the fix isn't released yet. That's why I stated "I'll include this in the next point release" 😄

I'll be sure to have this in for 0.34.4

[kolya182]

@alexanderbez 0.34.4 https://github.com/cosmos/cosmos-sdk/releases/tag/v0.34.4 is out but no fix for this ?

[alexanderbez]

@kolya182 no, v0.34.4 doesn't include any "fix" for this. We saw no need to change the custom serialization of coins (ie. coins are nil in this case). We're going to be changing the serialization completely so wanted to keep that for the next major release.

[kolya182]

@alexanderbez RPC returns inconsistent balance for address https://www.mintscan.io/account/cosmos1rwh0cxa72d3yle3r4l8gd7vyphrmjy2kydpnje, here is a video https://drive.google.com/file/d/1jqyGXRLF2Dla2k4fIyCrbVapGuJ9KS0s/view?usp=sharing . Should i create another issue or this is related ?.

[alexanderbez]

No @kolya182. The stargate API sits behind a load-balancer and the nodes it proxied requests to are behind/out of sync.

I'm not sure if stargate has resolved this, but maybe use a different public API for now.

/cc @faboweb

[kolya182]

https://cosmosapi-mainnet.tokenlon.im/auth/accounts/cosmos1633n6ga6zee5nz2uhtsn5urug8qzxthmz85ne9

https://stargate.cosmos.network/auth/accounts/cosmos1633n6ga6zee5nz2uhtsn5urug8qzxthmz85ne9

{
    "type": "auth/Account",
    "value": {
        "address": "",
        "coins": null,
        "public_key": null,
        "account_number": "0",
        "sequence": "0"
    }
}

[alexanderbez]

@kolya182 -- I'll have a PR up soon :)

[alexanderbez]

Two different REST client providers.