LCD deposits for proposals returns null

[sabau]

Summary of Bug

I was going to add a ticket but can be an extension of this:

https://stargate.cosmos.network/gov/proposals/4/deposits
Returns null -> probably because it's rejected, still I would expect an empty array
So probably this is related to:
#4114

https://stargate.cosmos.network/gov/proposals/5/deposits
returns null -> this Passed so we should have the deposits list

Probably adding the tests will fix it
#3094

Version

0.34.1

Steps to Reproduce

When I access a Passed proposal https://stargate.cosmos.network/gov/proposals/5/deposits
Then I should receive the list of deposits

When I access a rejected proposal https://stargate.cosmos.network/gov/proposals/4/deposits
Then I should receive an empty array (is this true? #4114)

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[fedekunze]

this is not a bug, it is part of the chain's pruning strategy and is expected. See #2880 for more details

[fedekunze]

oh you mean the REST response, then yes. I guess we need to return the empty array

[sabau]

For proposal 4 it's just null instead of []
But for proposal 5 it seems we are missing the deposits. I've seen that this is the behaviour for the getter, but for the REST endpoint I would expect the outcome to be the same, so in the background it should query the transactions, giving this extra effort to the cilents will move this extra complexity on their side

[alexanderbez]

It seems the governance module's client package is itself turning into a meta-client 🙁

It's the only module I know of that does these meta tx query aggregations for you...I don't know if we're heading down the right path here, but I guess it does help upstream clients a lot. Also doing proofs on this will be tough.

[sabau]

Agree! doing proofs would be tough!
I've seen a PR today that will mitigate this, seems not burning them at all unless vetoed or ignored:
#4374
It follows the porposal:
https://hubble.figment.network/cosmos/chains/cosmoshub-2/governance/proposals/6

[fedekunze]

moved to #4741