Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: remove x/ dependency on cmd/gaia #4351

Merged
merged 6 commits into from
May 17, 2019
Merged

Conversation

alessio
Copy link
Contributor

@alessio alessio commented May 16, 2019

This is an alternative patch to what is proposed in #4348

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

This is an alternative patch to what is proposed in #4348
@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #4351 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4351      +/-   ##
==========================================
- Coverage   58.11%   58.09%   -0.03%     
==========================================
  Files         235      235              
  Lines       14882    14882              
==========================================
- Hits         8649     8645       -4     
- Misses       5605     5609       +4     
  Partials      628      628

@alessio alessio changed the title remove x/ dependency on cmd/gaia R4R: remove x/ dependency on cmd/gaia May 16, 2019
@rigelrozanski rigelrozanski merged commit ca4363f into master May 17, 2019
@rigelrozanski rigelrozanski deleted the alessio/gaia-imports-in-x branch May 17, 2019 01:34
alessio added a commit to cosmos/gaia that referenced this pull request May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants